Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There currently seems to be lot of disabled, outdated code like selecting node transations on the translation set page.
Working on it...
Comment | File | Size | Author |
---|---|---|---|
#13 | 1153830_disabled.patch | 3.1 KB | Berdir |
#11 | Screenshot.png | 45.82 KB | Jose Reyero |
#4 | 1153830_neutral2.patch | 1.05 KB | Berdir |
#3 | 1153830_neutral.patch | 1.06 KB | Berdir |
#1 | 1153830.patch | 14.81 KB | Berdir |
Comments
Comment #1
BerdirOk, here is a first patch.
- The whole thing (adding and removing nodes to a translation set) should be working now.
- Also wrote some tests for it
- Fixed a bug in the tests base class and made it a bit more extensible (allow to provide additional admin permissions).
Comment #2
Jose Reyero CreditAttribution: Jose Reyero commentedLooks great, you even added some test, thanks!
This is committed. There are a few minor issues with this page though that we can fix with next patches:
- Language neutral showing up?
- Language names for fields.
(changed issue status to active, instead of fixed, though patch is committed)
Comment #3
BerdirOk, new patch to hide the language neutral row.
Comment #4
BerdirUpdated patch with a better comment.
Comment #5
Jose Reyero CreditAttribution: Jose Reyero commentedFixed, thanks.
Comment #6
Lars Toomre CreditAttribution: Lars Toomre commentedA small nit when reviewing this issue for examples of tests... I think that the middle test below was meant to make sure that the english autocomplete suggestion was found. Am I wrong?
Comment #7
BerdirActually, no. It was meant to make sure that the english autocomplete does *not* work when using the spanish autocomplete path.
Comment #8
Lars Toomre CreditAttribution: Lars Toomre commentedOK... But then what is the purpose of the third test? It appears to be like the first of the three just using a different parameter.
Comment #9
BerdirIt is. 1 and 2 test the same thing, just using two different languages. 2 tests that it does not work when using the wrong language.
Comment #10
Lars Toomre CreditAttribution: Lars Toomre commentedThanks for the explanation... I am learning more about testing all the time and am now including an in-line comment in my own code above what here was 1), 2) and 3). It helps me remember in plain text what condition was being tested for.
Comment #11
Jose Reyero CreditAttribution: Jose Reyero commentedI am seeing you get all languages for autocomplete (enabled and disabled ones) which is not consistent with other options (extended language option for nodes) and also not consistent with the list above.
See screenshot. Chinese and Portuguese are disabled languages.
Comment #12
BerdirOk, disabled languages are now hidden, test has been updated to catch this.
Comment #13
BerdirOk, disabled languages are now hidden, test has been updated to catch this.
Comment #14
Jose Reyero CreditAttribution: Jose Reyero commentedCommitted, thanks.
It works great now!
Comment #15
Jose Reyero CreditAttribution: Jose Reyero commentedKeeping our list clean.