Realizing this module is conceived to use SPC, perhaps this request falls out of scope, but it's why we cannot use this module as-is. iFrame support has been the most performant offering from OpenX zone codes we've found in that pageload times are not dependent upon the speed of the adserver.

Comments

cookiesunshinex’s picture

I created a separate issue #1160322: Possible to automatically re-load ads on sites with lots of Ajax?, but I believe I have answered my own question, and really need iframe support.

I've done some research and it appears that I need iframe support for the automatically refreshing ads when using OpenX on a site that has ajax pages so that the ads are reloaded periodically, even though the page is not refreshed in the browser.

I have switched to this module from the OpenAds module which is located at http://drupal.org/project/openads. That module does not have iframe support either and this module has been updated to support Single Page Calls.

Is there any chance that there will be support for iframe tags in this module?

bropp’s picture

I'd also love to have this feature (in the 6.x version as well), but am wondering how hard it would be to implement.

bropp’s picture

andy.s.clark’s picture

Status: Active » Needs review
StatusFileSize
new13.36 KB

Here's a patch that adds optional iFrame support. This patch also includes the changes introduced in:

andy.s.clark’s picture

StatusFileSize
new13.36 KB

Created replacement patch for comment #4 that replaces deprecated html element attributes. Allows for better HTML validation.

ex.
<frame frameborder="0" ... />
-to-
<iframe style="border: none;" ... />

andy.s.clark’s picture

StatusFileSize
new18.68 KB

New replacement patch. Found that it is necessary to keep "scrolling='no'" in the iframe tag; could not find a good CSS replacement (tried overflow: hidden;).
Also removed problem with whitespace warning when applying patch by changing line endings to UNIX style rather than DOS/Windows in a couple of files.

wuinfo - bill wu’s picture

Version: 7.x-1.x-dev » 7.x-1.2
Assigned: Unassigned » Carol Levesque
Issue summary: View changes
wuinfo - bill wu’s picture

Version: 7.x-1.2 » 7.x-1.x-dev

Will Check this on 7.x-2.x branch.

xamount’s picture

Has this patch been applied to 7.x-2.x branch? I tried applying it locally and I got some rejects. Iframe support for openx ads is a functionality that I need.