Needs review
Project:
OpenX
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
11 May 2011 at 17:36 UTC
Updated:
23 Feb 2015 at 16:16 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
cookiesunshinex commentedI created a separate issue #1160322: Possible to automatically re-load ads on sites with lots of Ajax?, but I believe I have answered my own question, and really need iframe support.
I've done some research and it appears that I need iframe support for the automatically refreshing ads when using OpenX on a site that has ajax pages so that the ads are reloaded periodically, even though the page is not refreshed in the browser.
I have switched to this module from the OpenAds module which is located at http://drupal.org/project/openads. That module does not have iframe support either and this module has been updated to support Single Page Calls.
Is there any chance that there will be support for iframe tags in this module?
Comment #2
bropp commentedI'd also love to have this feature (in the 6.x version as well), but am wondering how hard it would be to implement.
Comment #3
bropp commentedComment #4
andy.s.clark commentedHere's a patch that adds optional iFrame support. This patch also includes the changes introduced in:
Comment #5
andy.s.clark commentedCreated replacement patch for comment #4 that replaces deprecated html element attributes. Allows for better HTML validation.
ex.
<frame frameborder="0" ... />
-to-
<iframe style="border: none;" ... />
Comment #6
andy.s.clark commentedNew replacement patch. Found that it is necessary to keep "scrolling='no'" in the iframe tag; could not find a good CSS replacement (tried overflow: hidden;).
Also removed problem with whitespace warning when applying patch by changing line endings to UNIX style rather than DOS/Windows in a couple of files.
Comment #7
wuinfo - bill wu commentedComment #8
wuinfo - bill wu commentedWill Check this on 7.x-2.x branch.
Comment #9
xamountHas this patch been applied to 7.x-2.x branch? I tried applying it locally and I got some rejects. Iframe support for openx ads is a functionality that I need.