Integrate pathauto bulk generation

This looks great, thanks! Sorry for not being able to have a deep look to this yet. My only concern with the current approach is about having so much explicit dependencies on pathauto and nodes, when ET aims to handle entities in a general way.

However, sunday I'll have a full day to spend on Drupal and we should be able to move forward.

subscribe

Patch from #2 doesn't work with latest -dev release anymore

subscribe

das-peter, your patch from #10 works just great for me! I successfully updated aliases for my nodes (each of them in 3 languages). New node creation and translation is also OK.

Would be great, though, if it will be possible to add taxonomy support in future.

Looks like I found a minor bug. We have entity translatable node type, for which we didn't add rules for alias creation (and there are no default rules applicable), i.e. it is impossible to make alias programmatically for it. In case you'll add node of this type, and then will try to translate it, you'll receive this message after translation submission:

Notice: Undefined index: pathauto in entity_translation_entity_translation_save() (line 571 of /var/www/test2.sky37.com/public_html/sites/all/modules/entity_translation/entity_translation.module).

If alias automatic creation is possible, but you'll suspend it with "URL path settings" for this node, there will be no problem.

das-peter, hi. Patch from #13 completely solved this problem, thank you.

subscribe

#13 patch works great
please commit

I'm sorry I couldn't work on this yet, but the patch albeit working cannot be committed as is, explained above.

@planch can you explain further where you see problems and what you would like to change, so that others can help? This issue seems somewhat stuck.

The problem with the current approach is that it involves making a lot of special casing for nodes, while ET aims to handle entities in ageneral way. I'm seriously considering to use CTools to solve the different entities needs though plugins. But this obviously is a thing that must be carefully considered, the only problem is I am very busy with translatable fields in core to work on ET at the moment.

+1 for patch in #13 ! Thanks!

subscribe

subscribing.

I applied the patch in #13, which worked fairly well. However, I'm getting a bug - now when I go to bulk update my alias settings (URL Aliases->Bulk Update), the checkbox to update all content is missing. Is anyone else seeing this error?

Update: I cleared the cache and this was fixed.

Thi is likely to be addressed in a totally different way, see #1282018: Improve UX of language-aware entity forms.

based on #13 patch here is a patch that applies to the latest dev of this module (from 2011-10-11)

#25: entity_translation-add-hook-for-translation-event-1155134-20.patch queued for re-testing.

Rerolled patch as the one at #25 doesn't want to cooperate :)
This is very handy feature. Let's get this in.

#29 works well.

#29 works very well. Thanks, it is a very important feature!

I'm sorry but this won't be committed as is, see #24.

I'm working hard on #1282018: Improve UX of language-aware entity forms to have at least the functional side ready soon. I'm wary about committing a temporary fix because people might start heavily relying on it. However my plan is to release a second alpha before committing the UI revamp. If it won't be (functionally) ready in a week I'll commit this.

I'm sorry but the patch cannot be committed as is:

+++ b/entity_translation.admin.inc
@@ -338,6 +353,31 @@ function entity_translation_edit_form($form, $form_state, $entity_type, $entity,
+      // Create temporary decoupled stuff to avoid sideeffects.

Typo

+++ b/entity_translation.admin.inc
@@ -338,6 +353,31 @@ function entity_translation_edit_form($form, $form_state, $entity_type, $entity,
+        // Dead ugly - but do we prefer to duplicate the pathauto form on our own??

Wrong comment wrapping. Can we have a less colloquial comment? Also below.

+++ b/entity_translation.admin.inc
@@ -338,6 +353,31 @@ function entity_translation_edit_form($form, $form_state, $entity_type, $entity,
+       module_load_include('module', 'redirect');

Wrong indentation.

+++ b/entity_translation.api.php
@@ -49,3 +49,17 @@ function hook_translation_info($types = NULL) {
+ * Allow modules tor react on translation events.

Typo

+++ b/entity_translation.api.php
@@ -49,3 +49,17 @@ function hook_translation_info($types = NULL) {
+ *   The entity which is translated.

This sentence looks odd.

+++ b/entity_translation.api.php
@@ -49,3 +49,17 @@ function hook_translation_info($types = NULL) {
+

Missing example.

+++ b/entity_translation.module
@@ -546,3 +546,134 @@ function entity_translation_edit_form_info($form) {
+ * @param $entity_type
+ * @param $entity
+ * @param $langcode

Missing parameter documentation.

+++ b/entity_translation.module
@@ -546,3 +546,134 @@ function entity_translation_edit_form_info($form) {
+  // The user needs the permissoin and pathauto has to be disabled.

Typo

+++ b/entity_translation.module
@@ -546,3 +546,134 @@ function entity_translation_edit_form_info($form) {
+  // Trigger pathauto if module is available

Missing trailing dot.

+++ b/entity_translation.module
@@ -546,3 +546,134 @@ function entity_translation_edit_form_info($form) {
+  // Group by language

Missing trailing dot.

Ok, committed and pushed to the 7.x-1.x branch. Putting back to 'postponed'.

I did not the test this, I'm just confident this is actually RTBC as per the comments above. Everyone be warned that once the new UI is committed this might be reverted entirely.

I just installed the *dev* version of entity_translation (dated Jan 12, 2012) and am using Pathauto 7.x-1.0. The automatic path aliases are working as expected.

Thanks!
Kristen

The second last stanza is problematic:

  foreach ($language_nids as $language => $nids) {
    pathauto_node_update_alias_multiple($nids, 'bulkupdate', array('language' => $language));
    $context['sandbox']['count'] += count($nids);
    $context['sandbox']['current'] = max($nids); 
  }
  $context['message'] = t('Updated alias for node @nid.', array('@nid' => end($nids)));

The last line produces end() expects parameter 1 to be array, null given in entity_translation.module:749 because $nids does not exist outside the scope of the above foreach() loop. Due to the lack of documentation here, it's difficult to determine if $language_nids should be used instead, or if that line needs to be moved into the loop (at the bottom).

So this needs some work, but leaving as postponed as this can be taken care of whenever this issue get un-postponed. (However, it is currently broken in the dev branch, as this is already committed.)

#29: entity_translation-add-hook-for-translation-event-1155134-29.patch queued for re-testing.

...this is NW based on #41. We can set it to NR once we have an actual patch ready for review.

I use the path pattern [nodesymlink:menu-link:parents:join:/]/[nodesymlink:menu-link:title], but I'll only get the path of the source language. There's even no foreign language path created.

Here is a patch rolled against the ml_edit_form branch. Obviously it won't pass tests until it is merged in the main one, thus setting to postponed.

The juicy one is in the Pathauto queue, please review/test it: #1155132-18: Add Entity Translation support to Pathauto.

The previous patch did not work without having access to the pathauto widget.

Committed and pushed to the 7.x-1.x branch, thanks for your efforts!

FINALLY! Thanx, ...one less patch to babysit ;)

:)

I'm running the latest -dev versions of Entity, Entity Translation, and Pathauto. I have several nodes with translations using this module, and none of their translations have aliases generated with Pathauto, regardless of how many times I clear the cache or regenerate the aliases.

Has anyone else experienced this, or does anyone have any thoughts on what could fix this issue?

You need to patch pathauto, see #1155132: Add Entity Translation support to Pathauto.

@brycesenz yes I have the same problem. I reported it here in pathauto queue.

Reopening since we are missing bulk updates.

FYI, CRUD hooks have just been reintroduced in #1224590: Introduce entity translation CRUD hooks.

#867578: Add drush commands for bulk alias updating/deleting is related. I was looking at ET issues when I was working on it.

Here's a stab at adding support for pathauto bulkupdates...

Uh, last patch contained other stuff as well. Here's the proper one.

#59: pathauto-bulk-fix-1155134-59.patch queued for re-testing.

Reroll against HEAD.

Committed and pushed with some adjustment, thanks!

And a small follow-up.

Sorry for reopening the closed issue. I'm not exactly sure if I must post it this here but here it is...

The "patch" is not working with almost taxonomy related tokens. (I'm using the 7.x-1.0-beta2 version with patch included).

I have a token pattern like this:[node:field-myfield:parents:join-path]/[node:field-myfield]/[node:title] and when bulk updating the aliases get the original language tokens only of [node:field-myfield:parents:join-path] and [node:field-myfield] tokens.

Is perhaps a new issue related to tokens?? Thanks

Ina ny case you should open a new issue, since this one was only about introdcuing the functionality.