Check for the git code it would be great to have a drush dl possibility.

drush dl tagadelic-7.x-1.x

would help a few people ;)

Comments

clemens.tolboom’s picture

clemens.tolboom’s picture

Status: Active » Fixed

Thanks.

jtwalters’s picture

StatusFileSize
new6.57 KB

*EDIT: see #6*
The module didn't appear to be ported to 7.x at all.

jtwalters’s picture

Title: More porting to Drupal 7 needed » Please create a dev release for the 7.x-1.x branch
Status: Needs work » Fixed
StatusFileSize
new6.77 KB

*EDIT: see #6*
This patch gives me tagadelic blocks without errors...

flokli’s picture

Title: Please create a dev release for the 7.x-1.x branch » More porting to Drupal 7 needed
Status: Fixed » Needs work

Works for me, thanks :-)

Things fixed with this patch:

One thing left:

Acessing tagadelic/list/1,2,3 throws this fatal error:

Fatal error: Cannot use object of type stdClass as array in /var/www/babysounds.de/htdocs/includes/theme.inc on line 800

When visiting the next page, I also see the following errors (which seem to come from the page before):

Notice: Trying to get property of non-object in tagadelic_page_list() (line 150 [...]/sites/all/modules/tagadelic/tagadelic.module).
Strict warning: Creating default object from empty value in tagadelic_page_list() (line 150 [...]/sites/all/modules/tagadelic/tagadelic.module).
Notice: Undefined property: stdClass::$name in tagadelic_page_list() (line 151 [...]/sites/all/modules/tagadelic/tagadelic.module).
Notice: Undefined property: stdClass::$vid in tagadelic_page_list() (line [...]/sites/all/modules/tagadelic/tagadelic.module).
jtwalters’s picture

StatusFileSize
new10.63 KB

This should fix the issues you listed...

flokli’s picture

Title: Please create a dev release for the 7.x-1.x branch » More porting to Drupal 7 needed
Status: Fixed » Needs work

fixed them, getting close ;-)

but there are some new notices/strict warnings on tagadelic/list/1,2,3 :

Notice: Trying to get property of non-object in tagadelic_page_list() (line 150 [...]/sites/all/modules/tagadelic/tagadelic.module).
Strict warning: Creating default object from empty value in tagadelic_page_list() (line 150 [...]/sites/all/modules/tagadelic/tagadelic.module).
Notice: Undefined property: stdClass::$name in tagadelic_page_list() (line 151 [...]/sites/all/modules/tagadelic/tagadelic.module).
Notice: Undefined property: stdClass::$vid in tagadelic_page_list() (line 153 [...]/sites/all/modules/tagadelic/tagadelic.module).
Notice: Undefined variable: output in theme_tagadelic_list_box() (line 364 [...]/sites/all/modules/tagadelic/tagadelic.module).
Notice: Undefined variable: output in tagadelic_page_list() (line 156 [...]/sites/all/modules/tagadelic/tagadelic.module).
Notice: Undefined variable: output in theme_tagadelic_list_box() (line 364 [...]/sites/all/modules/tagadelic/tagadelic.module).
Notice: Trying to get property of non-object in tagadelic_page_list() (line 150 [...]/sites/all/modules/tagadelic/tagadelic.module).
Strict warning: Creating default object from empty value in tagadelic_page_list() (line 150 [...]/sites/all/modules/tagadelic/tagadelic.module).
Notice: Undefined property: stdClass::$name in tagadelic_page_list() (line 151 [...]/sites/all/modules/tagadelic/tagadelic.module).
Notice: Undefined property: stdClass::$vid in tagadelic_page_list() (line 153 [...]/sites/all/modules/tagadelic/tagadelic.module).
Notice: Undefined variable: output in theme_tagadelic_list_box() (line 364 [...]/sites/all/modules/tagadelic/tagadelic.module).
jtwalters’s picture

I found out that there was already a "stable" version located at https://github.com/berkes/tagadelic

I wish I had found out earlier so I didn't spend all that time fixing the broken 7.x-1.x branch. Anyway, try that one and see if it works better.

clemens.tolboom’s picture

Title: More porting to Drupal 7 needed » Please create a dev release for the 7.x-1.x branch
Status: Needs work » Fixed

@jtwalters [edit: and flokli]: sigh ... you should have created a new issue as your finding are not related to this particular issue
(remember: each issue has notification)

We now have a D7 branch and can so assign these to the D7 version ...

As the maintainer said in #1157380: Move D7 code to D.o the git repo's should be equal ... I do agree with you that two git repo's is awkward ... maybe you could file a new issue about that?

I fix this again ;)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.