AdvAgg - Notice: Undefined offset: in drupal_http_request() (in includes/common.inc). Backport D7 drupal_http_request. [#1160204]

Comment	File	Size	Author
#25	tests.jpg	147.71 KB	Peter Bowey
#19	advagg-1160204-18.patch	443 bytes	mikeytown2
#15	advagg-1160204-14.patch	9.43 KB	mikeytown2

Comment #5

mikeytown2 commented 17 May 2011 at 14:55

Title:

Various E' PHP Notices on a CLEAN Install

» AdvAgg - Notice: Undefined offset: in drupal_http_request() (in includes/common.inc). Backport D7 drupal_http_request.

What does your the site status message say in regards to advagg? These errors are a by-product of the async worker timing out before it sends a message back. Nothing to really worry about and the fix for this would slow it down quite a bit so I'm tempted to mark this as a won't fix. I should create a patch for pressflow/drupal to "fix" this issue and not have to slow it down... the other option is to backport the D7 drupal_http_request and use that if your using php5... which sounds like a good idea.

Log in or register to post comments

Comment #6

Peter Bowey commented 17 May 2011 at 15:01

Priority:

Normal

» Major

Checked my [nginx] server logs - after the above. Found this logged report:

2011/05/18 00:06:11 [alert] 2474#0: *307 stalled cache updating, error:0 while closing request, client: 75.125.82.136, server: 0.0.0.0:80

Log in or register to post comments

Comment #7

Peter Bowey commented 17 May 2011 at 16:10

Requested 'status message say in regards to advagg'

Status report
Pressflow	6.20
Access to update.php	Protected
Adv CSS/JS Agg - Asynchronous Mode	Already set to TRUE
Adv CSS/JS Agg - Socket Timeout	Already set to 1 seconds. Raw timer: 22.85
AdvAgg JS Compress - Callback	The callback is working correctly.
Configuration file	Protected
Cron maintenance tasks	Last run 52 min 30 sec ago

Log in or register to post comments

Comment #8

Peter Bowey commented 17 May 2011 at 16:18

#8 - Also found a code bug in [advagg_bundler.admin.inc]

  list($data, $rows) = advagg_form_print_r($data);
  $form['info']['advagg_bundler_info'] = array(
    '#type'         => 'textarea',
-    '#title'        => check_plain($row['filename']),
+    '#title'        => check_plain($rows['filename']),  // Note: $rows is the logic used here
    '#default_value'  => $data,
    '#rows'           => $rows-1,
  );

Log in or register to post comments

Comment #9

Peter Bowey commented 17 May 2011 at 16:30

The code 'idea' to use backport the D7 drupal_http_request is a great idea!
Seems we are battling' between D6 and D7, with the 'really' patient ones are waiting for D8 (ha!)

I am likely to hack-core the D6 with this ->

http://api.drupal.org/api/drupal/includes--common.inc/function/drupal_ht...

Log in or register to post comments

Comment #10

Peter Bowey commented 17 May 2011 at 16:42

#10 - Other logged errors noted (since clean install of advagg):

[18-May-2011 01:23:57] PHP Fatal error:  require_once() [<ahref='function.require'>function.require</a>]: Failed opening required './sites/all/modules/cck/theme/theme.inc' (include_path='.:/usr/share/pear:/usr/share/php') in /var/www/virtual/peterbowey.com.au/sites/all/modules/cck/content.module on line 176

[18-May-2011 02:06:33] PHP Fatal error:  Call to undefined function advagg_flush_caches() in /var/www/virtual/peterbowey.com.au/sites/all/modules/advagg/advagg_css_compress/advagg_css_compress.install on line 38

Log in or register to post comments

Comment #11

Peter Bowey commented 17 May 2011 at 17:23

Totally clean Pressflow install with barebones [core + views + cck]:

Changes made to [advagg] were:

ONE:

advagg_bundler.admin.inc

  list($data, $rows) = advagg_form_print_r($data);
  $form['info']['advagg_bundler_info'] = array(
    '#type'         => 'textarea',
-    '#title'        => check_plain($row['filename']),
+    '#title'        => check_plain($rows['filename']),
    '#default_value'  => $data,
    '#rows'           => $rows-1,
  );

TWO:

advagg.admin.inc

  $form['advagg_async_generation'] = array(
    '#type'           => 'checkbox',
    '#title'          => t('Generate CSS/JS files on request (async mode)'),
    '#default_value'  => variable_get('advagg_async_generation', ADVAGG_ASYNC_GENERATION),
    '#disabled'       => $ret['advagg_async_generation']['severity'] == REQUIREMENT_ERROR ? TRUE : FALSE,
-    '#description'    => t('Current State: !value', array('!value' => filter_xss($ret['advagg_async_generation']['value'] . ' ' . !empty($ret['advagg_async_generation']['description']) ? $ret['advagg_async_generation']['description'] : ''))),
+    '#description'    => t('Current State: !value', array('!value' => filter_xss($ret['advagg_async_generation']['value'] . ' ' . (!empty($ret['advagg_async_generation']['description']) ? $ret['advagg_async_generation']['description'] : '')))),
  );

With these two changes - I had no PHP 5.x E' notices, with all the same tests as above.

The only last issue is the slow 'async worker'!!! Give it time, and it finally gets 'out of its 'lazy bed' and walks 'slowly' to the kitchen for a coffee treat?? Duh

Log in or register to post comments

Comment #12

Peter Bowey commented 17 May 2011 at 17:52

After the 'above' changes the only 'serious bug' logs I get are these: (advagg)

    Notice: Undefined offset: 1 in drupal_http_request() (line 556 of /var/www/virtual/peterbowey.com.au/includes/common.inc).
    Notice: Undefined offset: 2 in drupal_http_request() (line 559 of /var/www/virtual/peterbowey.com.au/includes/common.inc).
    Notice: Undefined offset: 1 in drupal_http_request() (line 559 of /var/www/virtual/peterbowey.com.au/includes/common.inc).
    Notice: Undefined offset: 1 in drupal_http_request() (line 556 of /var/www/virtual/peterbowey.com.au/includes/common.inc).
    Notice: Undefined offset: 2 in drupal_http_request() (line 559 of /var/www/virtual/peterbowey.com.au/includes/common.inc).
    Notice: Undefined offset: 1 in drupal_http_request() (line 559 of /var/www/virtual/peterbowey.com.au/includes/common.inc).
    Notice: Undefined offset: 1 in drupal_http_request() (line 556 of /var/www/virtual/peterbowey.com.au/includes/common.inc).
    Notice: Undefined offset: 2 in drupal_http_request() (line 559 of /var/www/virtual/peterbowey.com.au/includes/common.inc).
    Notice: Undefined offset: 1 in drupal_http_request() (line 559 of /var/www/virtual/peterbowey.com.au/includes/common.inc).

Log in or register to post comments

Comment #13

mikeytown2 commented 17 May 2011 at 18:35

Looks like the D7 backport isn't exactly what I want... this is closer to my needs
http://hi.baidu.com/%C3%C6%C9%F9%B7%A2%B4%F3%B2%C6/blog/item/26ac9bdd226...

Log in or register to post comments

Comment #14

Peter Bowey commented 18 May 2011 at 00:49

Just installed the new [advagg] (latest .git).

I get this report just after module activation:

    Notice: Undefined variable: filetype in advagg_get_files_in_bundle() (line 1219 of /var/www/virtual/peterbowey.com.au/sites/all/modules/advagg/advagg.module).
    Notice: Undefined variable: filetype in advagg_get_files_in_bundle() (line 1219 of /var/www/virtual/peterbowey.com.au/sites/all/modules/advagg/advagg.module).

I then 'reports' as above consistently in use.

Log in or register to post comments

Comment #15

mikeytown2 commented 18 May 2011 at 00:51

Status:

Active

» Fixed

Status	File	Size
new	advagg-1160204-14.patch	9.43 KB

Here is the patch that I've committed. I'm going to assume this fixes the issue, let me know if nginx spits out any errors; I might have a workaround for it.

Log in or register to post comments

Comment #16

mikeytown2 commented 18 May 2011 at 01:00

@#14 that's a very strange error to get; here is the code in question

/**
 * Get list of files and the filetype given a bundle md5.
 *
 * @param $bundle_md5
 *   Bundle's machine name.
 * @return
 *   array ($filetype, $files)
 */
function advagg_get_files_in_bundle($bundle_md5) {
  $files = array();
  $results = db_query("SELECT filename, filetype FROM {advagg_files} AS af INNER JOIN {advagg_bundles} AS ab USING ( filename_md5 ) WHERE bundle_md5 = '%s' ORDER BY porder ASC", $bundle_md5);
  while ($row = db_fetch_array($results)) {
    $files[] = $row['filename'];
    $filetype = $row['filetype'];
  }
  return array($filetype, $files);
}

I SELECT filename, filetype and then use it in the row... if anything it should throw a SQL error.

EDIT: I see the error... stand by

Log in or register to post comments

Comment #17

Peter Bowey commented 18 May 2011 at 01:03

Just tried the above 'patch', 'after a clear cache event' - it looks good (no E' events logged)!

Went through all the usual events that prev. triggered the log - but is good.

Log in or register to post comments

Comment #18

Peter Bowey commented 18 May 2011 at 01:05

To #16 'EDIT: I see the error... stand by...'
I am one patch behind - already!
I had just done #15 (patch) :)

Log in or register to post comments

Comment #19

mikeytown2 commented 18 May 2011 at 01:06

Status	File	Size
new	advagg-1160204-18.patch	443 bytes

committed this patch for #14 :)

Log in or register to post comments

Comment #20

mikeytown2 commented 18 May 2011 at 01:09

Ended up changing that last patch; like this better:
http://drupalcode.org/project/advagg.git/commitdiff/817db3183af2ba863a64...

Snapshot download of the latest
http://drupalcode.org/project/advagg.git/snapshot/817db3183af2ba863a64de...

Log in or register to post comments

Comment #21

Peter Bowey commented 18 May 2011 at 01:10

#19 Patch works a treat, I see clean logs after several event tests! = Yay!!
Well done... :)

Log in or register to post comments

Comment #22

Peter Bowey commented 18 May 2011 at 01:13

To #20, I will try that later when it hits -> "git clone --branch 6.x-1.x http://git.drupal.org/project/advagg.git"
I must get a life :)

Log in or register to post comments

Comment #23

Peter Bowey commented 30 May 2011 at 01:27

Referring back to #12 - #13, I can see now why Wim Leers wrote his advanced aggregation / compressor in Perl!

Log in or register to post comments

Comment #24

Peter Bowey commented 18 May 2011 at 01:37

I have just done some hard testing, 'rebuilding aggregated files' etc..
I note that the build loop sometimes 'hangs'

Message: This request could not generate correctly. Loop detected. Request data: sites/default/files/advagg_js/js_7e6c60fca057b65f2973751cd2d3e23e_0.js

Referrer:	http://www.peterbowey.com.au/batch?op=start&id=2

Location:	http://www.peterbowey.com.au/sites/default/files/advagg_js/js_7e6c60fca057b65f2973751cd2d3e23e_0.js?redirect_counter=6

Log in or register to post comments

Comment #25

Peter Bowey commented 18 May 2011 at 01:52

Status	File	Size
new	tests.jpg	147.71 KB

Out of interest, this is how it currently appears at: http://www.webpagetest.org/result/110518_NG_MGX2/2/details/

Keeping in mind that [boost], [cdn] and [memcache] are NOT active (yet).

Log in or register to post comments

Comment #26

mikeytown2 commented 18 May 2011 at 02:18

in terms of a redirect loop I have an idea on how they might be caused
#1160890: Create uncompressed aggregate and then overwrite and save the compressed version.

Log in or register to post comments

Comment #27

Peter Bowey commented 18 May 2011 at 02:32

CSSTidy & JSMin+ are very expensive to run. Have an option to output the uncompressed aggregate first and then create a compressed version and do a rename operation to replace the uncompressed with the compressed. Hopefully this will take care of the advagg loops that happen.

'Sounds good'. Yes, I have JSMin+ statically compiled [not with pecl] into PHP-FPM.
Is [advagg] using PHP's [internal] CSSTidy and what advantage is it over some good 'regex' trimming?

Log in or register to post comments

Comment #28

Peter Bowey commented 18 May 2011 at 02:41

Refer #26

Have you seen this -> http://www.if-not-true-then-false.com/2009/css-compression-with-own-php-...

Log in or register to post comments

Comment #29

Peter Bowey commented 18 May 2011 at 02:51

I note this 'comment' on the Drupal CSSTidy module project page:

Known Issues
Pressflow

CSSTidy is not currently compatible with Pressflow.

See Pressflow bug: #597718: file.inc function file_create_url() not correct

Log in or register to post comments

Comment #30

Peter Bowey commented 18 May 2011 at 04:06

I am seriously thinking of 'patching' advagg's current "
function advagg_css_compress_css_tidy(&$contents)" to disable/bypass CSSTidy class.

This article made me think about this CSS event:
http://nadeausoftware.com/articles/2008/06/dont_bother_using_css_optimiz...
Thoughts?

Log in or register to post comments

Comment #31

mikeytown2 commented 18 May 2011 at 05:17

Just disable the compression module... simple as that. You still get core's regex whitespace compression.

Log in or register to post comments

Comment #32

mikeytown2 commented 18 May 2011 at 05:30

https://bugs.launchpad.net/pressflow/+bug/597718

file_create_url() would be an issue with the creation of the link in the HTML. It appears the reference to the CSS is correctly set, so this is something else.

Log in or register to post comments

Comment #33

Peter Bowey commented 18 May 2011 at 06:17

Thanks Mike,

Of interest, I replaced advagg's CSSTidy function in [advagg_css_compress.module] with this 'regex' code, and 'finally' the [Recreate all aggregated files] option actually completes (and without timeouts)....

function advagg_css_compress_css_tidy(&$contents) {
   $contents = preg_replace('!(/\*.*?\*/|^ | $)!is', '', $contents);
   $contents = preg_replace('![\s\t\r\n]+!', ' ', $contents);
   $contents = str_replace(array(' :', ': ', ' ,', ', ', ' ;', '; ', ' {', '{ ', ' }', '} '), array(':', ':', ',', ',', ';', ';', '{', '{', '}', '}'), $contents);
   $contents = str_replace(array(' 0px', ':0px', ';}', ':0 0 0 0', ':0.', ' 0.'), array(' 0', ':0', '}', ':0', ':.', ' .'), $contents);
   $contents = trim($contents);
}

With CSSTidy, I 'gave up' waiting for the completion of 'Recreate all aggregated files'.
No logged events either - with the simple regex (above).
So yes, CSSTidy is heavy hauling...

Log in or register to post comments

Comment #34

Peter Bowey commented 18 May 2011 at 06:32

#33 Regex method benchmarks at 8 seconds [Recreate all aggregated files]
Best case CSSTidy trials varied from 3 minutes to 'never completes' :)

Log in or register to post comments

Comment #35

Peter Bowey commented 18 May 2011 at 07:44

I then tried this 'new' PHP class method -> http://www.codenothing.com/archives/php/css-compressor/

This new code (replacing the CSSTidy Class used in advagg) bench-marked at 10 seconds.

I used 'sane' for the CSS optimize [css-compressor 3.0]
Cool

Log in or register to post comments

Comment #36

mikeytown2 commented 18 May 2011 at 22:01

Thanks for the heads up on that; it is MIT Licensed so I can include in the advagg download; which is something I plan on doing.
#1161870: Include the CSS Compressor

Log in or register to post comments

Comment #37

mikeytown2 commented 7 June 2011 at 17:06

Status:

Fixed

» Closed (fixed)

Log in or register to post comments

AdvAgg - Notice: Undefined offset: in drupal_http_request() (in includes/common.inc). Backport D7 drupal_http_request.

Comments