I am not able to get this to work. Not matter what sort of tag I enter nothing gets replaced. Also, every time I add a user tag it overwrites all sitewide tags, no matter what the names are. This is with the Feb 4th release, 5.x-1.2

CommentFileSizeAuthor
#5 reptag_php4js.patch4.06 KBprofix898

Comments

profix898’s picture

profix898 commented

Can you please post some details on your configuration? PHP, Apache, MySQL, OS, Browser, ... and what else seems important to you. I realized your post at http://drupal.org/node/112966. Is this bug report with disabled javascript features?

profix898’s picture

profix898 commented

Regarding "every time I add a user tag it overwrites all sitewide tags" this was actually a bug with something I messed up during the update to Drupal 5. I guess most people (including me) are using the AJAX version and therefore never recognized this bug. Fix committed to Drupal-5 branch. I will tag a new release once the other issues are fixed as well. Thanks.

But I still dont have an idea why the replacement process doesnt work for you. Have you tried some other tags, e.g. {DATE} or any other module tag? It may also be related to the incorrectly saved tags. Can you please try the latest Drupal-5 cvs version and confirm that the bug is still there!?

cowhead’s picture

cowhead commented

I reinstalled and still get both errors. I'm using php 4.4.4 and mysql 4.0.27 on an apache server running centOS. I get the same errors w/ firefox 2 and IE7.

I have tried it on two sites, one with a few modules, and one with nothing but drupal core a couple of drupal's option modules.

Perhaps I'm doing something wrong? I have read over the directions and I don't think I've missed anything obvious.

This problem is with all tags, both custom and things like {DATE} {SITE}

profix898’s picture

profix898 commented
Priority: Normal » Critical

I got a few hints on the issues you reported. I just installed the same PHP/MySQL versions as you on my development box. Good new (or bad news for me ;)) the issue is related to the PHP version. I works nicely with PHP5.x, but some of the features I added for 1.2 seem broken with PHP4.x. I already narrowed it down to one line in reptag_process(). It shouldnt be too difficult to fix that.
The Javascript/AJAX issue happens with PHP4.x and CleanURLs enabled only. I will try to fix both issues and report back in about 24h. Its time to sleep where I am ;) Thanks again for granting me acceess to your site's configuration. Hope you will have a working reptag version soon.

profix898’s picture

profix898 commented
Status: Active » Needs review
StatusFileSize
new reptag_php4js.patch4.06 KB

Attached is a patch that should fix the issues with PHP4 and CleanURLs. Not 100% about the javascript one, I experienced problems with javascript myself (using your server configuration), but I got a different error message. However with this patch javascript seems to works nicely.

manveru’s picture

manveru commented
Title: Not replacing » Not replacing - patch working well

Your patch is working at my configuration very well. Please release it ASAP - it may help many using this module.

profix898’s picture

profix898 commented
Title: Not replacing - patch working well » Not replacing with PHP4.x
Status: Needs review » Reviewed & tested by the community

As per manveru, setting RTBC. Thanks for review. I think an updated release will be available within <48h.

profix898’s picture

profix898 commented
Title: Not replacing with PHP4.x » Not replacing with PHP4.x and 403 for AJAX cb with clean urls
profix898’s picture

profix898 commented
Status: Reviewed & tested by the community » Fixed

Committed to Drupal-5 branch.
If there is still an issue with ajax/javascript please post to http://drupal.org/node/112966 instead.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)