This patch adds support for --pipe. It only displays minimally cleaned up commits on the page without any HTML markup.

It is dependent on the changes in #1162182: Alternate baseurl for issue links.

CommentFileSizeAuthor
#6 grn_1164262_6.patch2.03 KBJosh The Geek
#4 grn_1164262_3.patch1.96 KBJosh The Geek
grn.pipe_support.patch1.96 KBGrayside

Comments

Josh The Geek’s picture

Josh The Geek commented
Category: feature » task
Status: Needs review » Fixed

Commited.

Josh The Geek’s picture

Josh The Geek commented
Status: Fixed » Needs work

What the heck? I forgot to review the darn thing first. It reverted it.

+++ b/grn.drush.inc
@@ -82,7 +82,15 @@ function drush_grn_release_notes($tag1n, $tag2n) {
+  $output = _drush_grn_format_changes($changes, $tag1n, $tag1[0], $tag2[0], $git);

The variable in this scope is output,...

+++ b/grn.drush.inc
@@ -82,7 +82,15 @@ function drush_grn_release_notes($tag1n, $tag2n) {
+    drush_print_pipe(array_keys($items['raw']));

But this

+++ b/grn.drush.inc
@@ -82,7 +82,15 @@ function drush_grn_release_notes($tag1n, $tag2n) {
+    drush_print($items['rendered']);

And this use $items.

Josh The Geek’s picture

Josh The Geek commented
Status: Needs work » Needs review

Attached. I just changed the $output to $items.

Josh The Geek’s picture

Josh The Geek commented
StatusFileSize
new grn_1164262_3.patch1.96 KB

Or not.

Josh The Geek’s picture

Josh The Geek commented
Status: Needs review » Needs work

All three hunks fail miserably. I have committed a bunch of things since this patch was made, so it should just need a reroll.

Josh The Geek’s picture

Josh The Geek commented
Status: Needs work » Needs review
StatusFileSize
new grn_1164262_6.patch2.03 KB

Okay, I hand applied the patch and got this. It applies fine, and I'm testing it now.

Josh The Geek’s picture

Josh The Geek commented
Status: Needs review » Fixed

Okay! Tested, committed and pushed. Release time!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.