target="_new" incorrectly added to javascript actions [#1166990]

Hi!
I have found that child.js would add target="_new" to links with href="javascript:whatever();", which causes an unwanted new browser tab to open every time the link is clicked.
A possible solution to this issue would be changing the conditional
if (!href || href.length <= 0 || href.charAt(0) == '#') return;
to
if (!href || href.length <= 0 || href.charAt(0) == '#' || href.indexOf('javascript:') > -1) return;

Should I fix it myself and submit the code or wait until the developer agrees with it? It's my first post in Drupal.org, so any help would be appreciated ^^.
Thanks!

Comment	File	Size	Author
#3	target=_new_incorectly_added_to_javascript_actions-1166990-0.patch	592 bytes	tobey_p

Comments

Comment #1

lelizondo commented 31 July 2011 at 10:22

I'm also getting this behavior

Comment #2

lelizondo commented 31 July 2011 at 10:27

I couldn't find the lines you're referring to. I ended up changing the JS to not add the target

Comment #3

tobey_p commented 8 August 2011 at 14:25

Status	File	Size
new	target=_new_incorectly_added_to_javascript_actions-1166990-0.patch	592 bytes

I was working on the same problem and did'nt noticed that there is already an issue for this.

I came up with a quite similar solution, but instead of "indexOf()" i used "substr()",
so its for sure that "javascript" is at the begining of the "href".
Additionally i added "toLowerCase()" to take into account that the keyword is maybe written uppercase.

Attached is a patch file.