Add support for devel to generate relations

[Stock Response - Relates to issue ]

This relates to #616160: Extending devel generate

From the relation.test

function createRelationTypes() {
    $this->relation_types['symmetric'] = array(
      'relation_type'   => 'symm' . $this->randomName(),
      'label' => 'symm' . $this->randomString(),
      'source_bundles' => array('node:article', 'node:page', 'term:*'),
    );
    $this->relation_types['directional'] = array(
      'relation_type'   => 'dir' . $this->randomName(),
      'label' => 'dir' . $this->randomString(),
      'directional' => TRUE,
      'source_bundles' => array('node:article'),
      'target_bundles' => array('node:page'),
    );
    $this->relation_types['octopus'] = array(
      'relation_type'   => 'octo' . $this->randomName(),
      'label' => 'octo' . $this->randomString(),
      'min_arity' => 3,
      'max_arity' => 5,
      'source_bundles' => array('node:article', 'node:page'),
    );
    foreach ($this->relation_types as $relation_type) {
      relation_type_save($relation_type);
    }
  }

and testDropzonePickCreate we can can boil some code to generate this I guess.

Please merge patch #4 and #5 :-)

I added a form to /admin/config/development/generate/relation

Works nice but when selecting kill we should add 'x relations deleted' I guess.

Furthermore it's hard to find new relations ... or do I miss a path?

[Stock Response - Needs review ]

The attached patch needs review

On an empty database generating relations gives errors.

I added required to relation types fields and checked for generated rids count

I'm not sure whether this test is enough

if ($available_types) {

The patch in #10 is ok when there are no 'Source and Target bundles' defined on ie admin/structure/relation/manage/relation-name

But not when there is no content.

@naught101 : we discussed the creation of relationships through code and ended up with

sa="@drupal.d7 --yes"

drush $sa site-install
drush $sa en devel_generate coder_review views_ui advanced_help graphapi_relation

drush $sa genu 10
drush $sa genc 10 0

drush $sa vset devel_error_handler 2

drush $sa ev '$type = relation_type_create(array("relation_type" => "donation", "directional" => TRUE,
    "source_bundles" => array("node:*"), "target_bundles" => array("node:*"),
        "label" => "donated to", "reverse_label" => "received donation from", ));
  relation_type_save($type);'
drush $sa ev '$type = relation_type_create(array("relation_type" => "similar", "directional" => FALSE,
      "source_bundles" => array("node:*"), "target_bundles" => array("node:*"),
          "label" => "is similar to"));
    relation_type_save($type);'
drush $sa ev 'relation_generate_relations();'

Why can't we get these relation types into the relation_generate code? We do have entity_get_info() to pop-out a list of entity:bundle combinations right?

@chx I didn't knew we had a drush command now for generating relations.

Nice solution moving the code out of relation.admin.inc to relation.drush.inc :)

But we still fail to have a command to generate relation types.

drush $sa ev '$type = relation_type_create(array("relation_type" => "donation", "directional" => TRUE,
    "source_bundles" => array("node:*"), "target_bundles" => array("node:*"),
        "label" => "donated to", "reverse_label" => "received donation from", ));
  relation_type_save($type);'
drush $sa ev '$type = relation_type_create(array("relation_type" => "similar", "directional" => FALSE,
      "source_bundles" => array("node:*"), "target_bundles" => array("node:*"),
          "label" => "is similar to"));
    relation_type_save($type);'

Attached patch fixes some args.

The patch still needs review but the test for how many relations created is puzzling me.

Currently doing a

drush genrel

generates 20 relations instead of the default setting of 10. So testing count($new_rids) == $number_relations is incorrect. $number_relations is half of count($new_rids).

This is due to arity as for each arity a relation is created ... see

$arity = rand($relation_type->min_arity, $relation_type->min_arity);
    for ($i = $number_relations; $i > 0; $i--) { // start new relation
      $entity_keys = array();
      for ($r_index = 0; $r_index < $arity; $r_index++) {

Note that min_arity is used twice! So this part I don't get :(

Replacing the error flow by

count($new_rids) > $number_relations

feels awkward but it is still better when used by

drush genrel

Please apply patch #16 then as that fixed arg defaults. With last remark from #17

Replacing the error flow by

count($new_rids) > $number_relations

Ehrm ... the status value should be (and was) ok. I added the 'error' and (needed to) fixed the arg for

+++ b/relation.drush.inc
@@ -29,19 +29,19 @@ function relation_drush_command() {
-function relation_generate_message($message) {
+function relation_generate_message($message, $status) {
   if (function_exists('drush_log')) {

Fixed argument

I got a message "Generated 10 ..." when these was no generation at all. Because I had no entities and/or relation_types.

+++ b/relation.drush.inc
@@ -112,6 +112,6 @@ function relation_generate_relations($number_relations = 10, $types = array(), $
-  relation_generate_message(t('Generated @number_relations relations.', array('@number_relations' => $number_relations)), 'ok');
+  relation_generate_message(t('Generated @number_relations relations.', array('@number_relations' => count($new_rids))), (count($new_rids) == $number_relations) ? 'ok' : 'error');

Operator == should be changed into >=

This still gives an error if for some reasons no relation is created.

Ah ... now I get it :p

dsm knows 'status', 'warning', 'error' so indeed we need to transform between 'ok' and 'status' depending on the context.