Provides additional field formatters for file fields.

Currently provides the following formatters:

  • Link to file (with custom title)

Differences with the approach of Media and Styles are:

  • File formatters only extends the core File module. When following the approach of media and styles, you need to install the following modules: Media, Ctools, File Entity, Styles.
  • The approach of the Media module needs configuration (I'm not sure how much though). With file formatters, you only need to enable the module and you can start using the formatters right away. IMHO file formatters is much easier to use for site admins, especially for people new to Drupal.
  • No overhead (in terms of complexity and performance) with file formatters, the module does what it says. No more no less.

Project page: http://drupal.org/sandbox/zilverdistel/1167036

Comments

ccardea’s picture

ccardea commented

Hello zilverdistel,

Sorry it took so long for someone to get to your project application. I conducted the initial review of this project.

Module duplication: I verified that the module provides new functionality that is not provided in core or by any other contributed module.

Licensing: The project has no third party libraries or other license issues.

This project is ready for technical review.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Needs work

Can you discuss some of the reasons to use this approach rather than Media with Styles?
Thank you.

zilverdistel’s picture

zilverdistel commented
Status: Needs work » Needs review

1. I'm only extending a core module. When following the approach of media and styles, you need to install all these modules:

  • Media
  • Ctools
  • File Entity
  • Styles

2. The approach of the Media module needs configuration (I'm not sure how much though). With file formatters, you only need to enable the module and you can start using the formatters right away. IMHO file formatters is much easier to use for site admins, especially for newbies.

3. No overhead (in terms of complexity and performance) with file formatters, the module does what it says. No more no less.

I hope this answers your question, but feel free to ask if more clarification is needed.

I'm setting the status to 'needs review', but I'm not sure if that is the right workflow or not.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Assigned: Unassigned » tim.plunkett

That is a great explanation, thank you. I didn't mean for you to go on the defensive, it's just a question that needed to be asked, and an answer I hoped you'd thought about. I would recommend putting this both in the OP above (you can edit those now) as well as the project page.

Assigning to myself for further review.

zilverdistel’s picture

zilverdistel commented
Issue summary: View changes

Updated issue summary.

zilverdistel’s picture

zilverdistel commented
Issue summary: View changes

Updated issue summary.

zilverdistel’s picture

zilverdistel commented
Issue summary: View changes

Updated issue summary.

zilverdistel’s picture

zilverdistel commented

Thank you for your suggestion. I added a section that explains the differences between this approach and the approach with Media and Styles, both in the OP and the project page.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work

* git release branch missing, see http://drupal.org/node/1015226
* README.txt missing
* Remove all old CVS $Id tags, not needed anymore
* you depend on the file module, do you also need to depend on the field module?
* Indentation errors, always use 2 spaces. Run coder to check your code style: http://drupal.org/project/coder
* don't use a switch() statement if you just have one case implemented. An if statement should do it.

zilverdistel’s picture

zilverdistel commented
Status: Needs work » Needs review

Since the file module depends on field, I don't think there needs to be an explicit dependency in file_formatters.info.

The other issues have been addressed in

http://drupalcode.org/sandbox/zilverdistel/1167036.git/commit/c4ea4f21a9...

I've also created a dev branch: 7.x-1.x.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community

file_formatters_field_formatter_settings_form(): what is the $options variable for?

Otherwise RTBC for me. Now while we are waiting for the access grants to create full projects would you be so kind to do a review of the other applications pending? Just pick one from this list: http://drupal.org/project/issues/projectapplications?status=8

zilverdistel’s picture

zilverdistel commented

I removed the $options variable, it must have been a left-over. I'll pick an application to review from the list.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Thanks for your contribution, zilverdistel! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in minde: Commit messages - providing history and credit and Release naming conventions.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.