Download & Extend

7.x-3.x undefined variable $module

Project:Views Slideshow
Version:7.x-3.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

$module is used on line 202, but it hasn't been defined.

http://drupalcode.org/project/views_slideshow.git/blob/refs/heads/7.x-3....

194 $form['widgets'][$location_id][$widget_id]['weight'] = array(
195 '#type' => 'select',
196 '#title' => t('Weight of the !name', array('!name' => $widget_info['name'])),
197 '#default_value' => ($this->options['widgets'][$location_id][$widget_id]['weight'] > count($widgets)) ? count($widgets) : $this->options['widgets'][$location_id][$widget_id]['weight'],
198 '#options' => $weights,
199 '#description' => t('Determines in what order the !name appears. A lower weight will cause the !name to be above higher weight items.', array('!name' => $widget_info['name'])),
200 '#states' => array(
201 'visible' => array(
202 ':input[name="style_options[widgets][' . $location_id . '][' . $widget_id . '][enable]"]' => array('value' => $module),
203 ),
204 ),
205 );

Comments

#1

I wasn't able to recreate the error that made me investigate that line of source code.
However, it looks suspicious nonetheless.

On IRC, redndahead suggested exchanging 'value' => $module with 'checked' => TRUE.

#2

Status:active» fixed

This patch was committed.

AttachmentSize
1167310-undefined_module-1-d7.patch 908 bytes

#3

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here