Needs review
Project:
Hidden Content
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
8 Feb 2007 at 02:13 UTC
Updated:
8 Jul 2008 at 23:06 UTC
Jump to comment: Most recent file
Comments
Comment #1
davemybes commentedTurns out it was much easier than I thought...this seems to work on Drupal 5.1. Patch rolled against 5.x-dev version.
Comment #2
Christefano-oldaccount commentedThis is interesting. Is anyone using this?
Comment #3
dnewkerk commentedHere is a new patch against the current dev version, works as of July 4, 2008. I've also run the module through Coder module and cleaned everything up to Drupal coding standards.
To clarify the purpose of this patch: it adds an actual Drupal permissions option to Roles, so you can specify that a given role can always see hidden content (without having to write it within every hidden tag) and also as such solves the issue of the admin no longer seeing hidden content if other roles are specified.
Please test the patch and commit when ready. This may need security review. Thanks!
Drupal 6 version also:
I have also made an alternate patch based on this to apply "after" my Drupal 6 port patch, in case anyone would like to use this feature on Drupal 6. You must first apply the Drupal 6 port patch against the current 5.x dev, and then the D6 version of this patch second.
Please make sure you use the correct patch for your version of Drupal
- David
Comment #4
Apfel007 commentedHi David,
I have several problems to patch the module..( newbie - sorry :-))! Can you explain me again what i have to do?
Do I need to patch with your 2 Versions (hidden_content-d6port, hidden_content_access_6port) after an other? Or is one enought? An what about the directory in your other post? Where is it?
I use cygdrive und write this:
>> patch < hidden_content....module
Is this right?
Cheers Kai
Comment #5
dnewkerk commentedHello Kai -
If you are using Drupal 5:
The Drupal 5 version upgrades the Drupal 5 version of the module with the new features and cleaned up code, for testing. Once you apply this patch you cannot currently upgrade the patched copy to Drupal 6 (must use an original version for that).
If you are using Drupal 6:
The Drupal 6 version of this patch for adding the new features only adds the features after Drupal is already patched with the port to 6 - the module has to be upgraded first to Drupal 6 first using the D6 port patch. Please do not apply this patch and then try to patch to upgrade to Drupal 6 afterward - it will not work.
Comment #6
Apfel007 commentedThanx David it works!!
Comment #7
dnewkerk commentedGreat to hear! I'm currently waiting for response from the module maintainer regarding my request to become a co-maintainer. If I don't hear back within 2 weeks (starting 2 or so days ago) I'll be able to send the request to the drupal.org webmasters and be given access - so within 2-3 weeks the module should be officially upgraded for both Drupal 5 and 6, or perhaps sooner if the current maintainer returns before then.
If anyone else could please test these patches to confirm further that would be great... and if anyone can assess any security implications (since this has to do with access control) then I'd love any feedback on that.
- David