double VAT

I think this might be due to a recent(ish) change in Ubercart 6.x-2.x-dev

Can you try with 6.x-2.4 instead, or revert the patch from #898776-9: Tax calculation doesn't use altered prices and see if that helps?

Hi Longwave,
I can confirm that in Ubercart 6.x-2.4 the calculation works but with the latest 6.x-2.x-dev (2011-Jun-23) it does not.
However, if I check to display VAT in the carts table, the VAT calculation is fine in there. Just the line items are not correct.

Did look into this more thoroughly and it seems that root cause for this is as follows:
- as patch #898776-9: Tax calculation doesn't use altered prices was applied to Ubercart 6.x-2.6 each product line item price is calculated using uc_price() - instead of $item->price x $item->qty
- uc_vat module has uc_price() alter to calculate prices inclusive of VAT
- as a summary of this, while tax/vat amount is being calculated, taxable amount is inclusive of tax/vat (on previous versions it was exclusive of VAT) and thus, tax line item is incorrectly calculated (causing both subtotal excluding VAT and tax amount shown incorrectly at checkout)

@longwave already predicted this while patch was applied (see reply #13 in #898776-9: Tax calculation doesn't use altered prices)

Please find patches both for uc_taxes.module and uc_vat.module to fix tax line item calculations

Oops ... I must have mess up something while doing patches. Re-applied below.

Thanks again.
It works great for me.
It is indeed big problem for ubercart users with vat support.

IMHO the new release of uc_vat and ubercart should be released as soon as posible.

I have tested the patch ggalante supplied.
(Thanks for your work)
My review order site displays correct vat.

But I don't see vat line on /cart site
having following options checked.
Cart and checkout options
x Show VAT amounts in the cart and at checkout.
x Show VAT amounts in separate columns at checkout.

PS. I have applied this patch on clean ubercart 2.6 and clean uc_vat 6.x-1.2.

I reverted mitrpaka's patches before applying my own.

Currently we are using my patch on our site, with no adverse side effects. But we don't have very much complexity in our cart, so I can't be certain of the effectiveness of my patch without more thorough testing.

I'm swamped for the next 3 weeks, so if anyone else could do a deeper test, by all means. I would be extremely grateful. Normally I'm more thorough, but sometimes life hands you way too many lemons. :)

Hi ggalante,

Your patch also removes tax on line items while they're still in the cart. In our case we show inclusive pricing in the cart and they are incorrect after your patch.

Willem

@wjroes: As I said, my solution while closer to the problem, isn't a full solution. I apologize, but this problem seems to require a very deep understanding of both uc_vat and ubercart. I don't have time to catch myself up. What we really need is either a.) longwave to finally come back from wherever he is hiding, or b.) someone take his place, catch up on what needs doing, and apply a change in an official capacity.

@Taart: Why can't you simply apply the patch files to your local copy, and then push up the changed files to your host? It's no different from making changes to any other files on your site.

-G

@ggalante

I don't know much about patching, but I'm on Windows, no Git installed. I manually altered the files, but then my incl. VAT prices show up without VAT in the shopping cart, doesn't look right to me.

Inspired by ggalante's patch in #10, I also made an attempt to fix this. As mitrpaka said in #5, the problem that occurs is that the tax calculation is based on the tax inclusive price. Taxes should always be based on the tax exclusive price of course.

1. The problem starts in uc_vat_apply_tax() where uc_vat asks the uc_taxes module for the taxable amount for each product: uc_vat calls uc_taxes_apply_item_tax().
2. The uc_taxes module calls the function uc_price() to get the taxable amount, but says it want's the taxable amount to be based on the altered price.
3. The function uc_price() thinks: so it wants the amount based on the altered price? No problem, then I will just ask all price alters to give me that.
4. Then the uc_vat module receives a request to return the altered price, function uc_vat_price_handler_alter() gets called. For product prices it returns the tax inclusive price.
Result: the taxable mount is the product price inclusive taxes.

So, I assumed all we need to do is notify the uc_vat-module it should not do any price alters under certain circumstances. The patch of ggalante generaly says "do not do the uc_vat price alter when the context is 'cart_item' or 'product'". But that will result in tax inclusive prices to disappear in the cart and on product pages, which is not a desired behaviour, at least not for me.

I noticed price alter functions receive an array of options as a parameter. What if we could set an option there that tells the uc_vat-module to not do any price alters? When calling uc_taxes_apply_item_tax(), we are not able to add an option, thus if we would set an option then calling uc_taxes_apply_item_tax() will be a no-go.

So, in my attempt to fix this issue I copied over uc_taxes_apply_item_tax() to the uc_vat module and called it uc_vat_uc_taxes_apply_item_tax(). Then I was able to set an option before the price request is sent to uc_price(). And so I did. I defined an option called 'uc_vat' and set this to FALSE to indicate price alters done by uc_vat should be bypassed. In the price alter function of uc_vat (uc_vat_price_handler_alter()), I added a check for this option, and if it was set to FALSE, then the price alter function will cancel it's price alterations.

This was my setup when creating and testing the patch:
- Ubercart v6.x-2.6
- Ubercart 2 VAT support v6.x-1.2
- Ubercart Discount Coupons v6.x-1.7
- Two active tax rates
- No shipping rates

I didn't test the patch under other circumstances then those above, so I can't guarantee it will work perfectly under all kinds of conditions.

@Taart
Do you have the "Allow per line-item tax adjustments" setting enabled? This setting can be found on the settings page for uc_vat. See attachment for my settings.

I can confirm that when reverting back to ubercart 2.4 the double VAT issue disappears.

@MegaChriz, no, but now I did and it seems to work. Thanks!

In addition to my post above:
I noticed a further problem. On the payment, by Paypal the tax is still wrong and the total sum is one cent to high.

Why is there shown so much information on the paypal page? I think it should be enough to show the total sum, which the customer wants to pay. Is this possible?

@WebsiteJo

I had the same problem and I believe this is because of differences in de precicion of prices excluding VAT calculated in 'Ubercart 2 VAT support' and the prices sent to paypal.

Let's say you want your price including vat to be 10€ with a VAT rate of 21% then you would enter (10/121)*100 = 8.26446
8.26446 * 0.21= 1.7355366 VAT + 8.26446 = 9.9999966 => Rounded to a precision of 2 after the comma this will be 10€
But paypal only gets 8.27 which is the amount excluding VAT rounded to 2 after the comma.
8.27 * 0.21 = 1.74 VAT + 8.27 = 10.01€

What I do is I enter my prices excluding VAT with less precision so I have the same result in ubercart as in paypal.
You could also change the payment method setting in /admin/store/settings/payment/edit/methods and select "Submit the whole order as a single line item." for the "PayPal cart submission method"

www.AffordIT.be

See #1081130: VAT in invoice calculated on Total not subtotal (ubercart > 2.4)

i use ubercart verson 2.7 and vat 2.1
with ubercart 2.4 vat/tax works fine!

for ubercart 2.7:
patch http://drupal.org/node/1170992#comment-5062982 doesnt work because there is no function uc_vat_uc_taxes_apply_item_tax!!!!
but the patch at http://drupal.org/files/issues/uc_taxes.module_4.patch seems to work!!

I use no uc_vat patch.
example: http://www.muenzboxen-muenzkapseln.de/

but there is another problem with the shipping cost. ubercart or the vat module add the shipping cost (without tax) to price with tax an then calcualte the total tax. thats wrong!

@WebsiteJo
now it works

This is what has worked for us.

We applied the patch #20. This resolved the issue that manifests itself on the checkout/review page. It doesn't resolve the issue associated with invoices and in our particular case, PayPal.

To resolve the incorrect amount of VAT being passed to PayPal we have applied part of the patch at #19 at http://drupal.org/node/1081130. We only applied the first element of the patch as the second is covered by the patch at #20.

These patches have been applied to uc_vat 6.12

We're using Ubercart 6.26

Hope this helps.

@WebsiteJo I've tried your uc_vat.module but it has a strange behaviour which I'll explain with an example.

Cart is resuming correctly:

During cart/checkout, I add the shipping quote and all values are fine:

Those two splitted VAT lines are also present on order summary and invoice.
The algebraic sum is correct (2.18-0.24=1.94 out of one rounding cent), but the splitting is not.

This is my configuration (developement environment):

• Ubercart 6.x-2.x-dev (2011-Nov-19)
• Ubercart 2 VAT support 6.x-1.2 your uc_vat.module
• Ubercart Discount Coupons 6.x-1.7
• admin/store/settings/taxes
• Name: IVA 21%
• Rate: 0.21
• Taxed products: Apply tax to any product regardless of its shipability
• Taxed product types:
• Product
• "Blank line" product
• Taxed line items:
• Coupon discount
• Shipping
• Empty line
• admin/store/settings/taxes/vat
• Price display options
• Tax name: IVA
• Add "including IVA" to tax inclusive product prices: no
• Add "price excluding IVA" to tax inclusive product prices: no
• Add "no IVA applicable" to zero-rated product prices: no
• Add "excluding shipping costs" to shippable product prices and cart displays: no
• Show prices excluding IVA to the superuser: no
• Price editing options
• List price: no
• Cost: no
• Sell price: no
• Cart and checkout options
• Show IVA amounts in the cart and at checkout: yes
• Show IVA amounts in separate columns at checkout: no
• Hide the "Subtotal" line item at checkout: no
• Hide IVA exclusive prices and "Subtotal excluding IVA" line item: no
• Advanced options
• Keep IVA inclusive prices the same after a rate change: no
• Allow per line-item tax adjustments: no

Allow per line-item tax adjustments(requires patch to uc_taxes.module): yes

That did the trick ! Now the behaviour of vat is correct in every step.
Thank you very much WebsiteJo.

I think that patch #42 should be commited, so changed the state of the issue in the hope of maintainer's help.

#42 also worked for me!
Will it be included in uc_vat 6.x-1.3 ?

Mmm … maybe I spoke too soon. On the order review page I’m getting a line with the VAT that would be applied to the already VAT inclusive price, preceded (or followed) by a line with an adjustment (a negative number) to the VAT bringing it to the correct amount. For example, for a purchase of 800 HUF with a VAT rate of 25% and 0 for shipping it looks like this:

Subtotal 1,000 HUF
Shipping 0
Subtotal excluding VAT 800 HUF
VAT - 50 HUF
VAT 250 HUF
Total 1,000 HUF

I’m configured with the following

Ubercart 6.x-2.7
Ubercart 2 VAT support 6.x-1.2 with mod from #42 above
Ubercart Discount Coupons 6.x-1.7
Ubercart Addresses 6.x-1.0
Ubercart Views 6.x-3.1
Ubercart Webform Checkout Pane 6.x-3.5

I’m attaching my VAT (ÁFA) settings.

The weird thing is sometimes the negative VAT line shows up first, other times the overinflated one. I don’t have the cart showing VAT, and the payment page is fine thanks to #42. Can anyone please help?

Thanks @MegaChriz! So, about those bee knees …

It works, but now I have two lines
One line with the old VAT and one negative VAT.

Can we change this?

Had troubles with incorrect taxes as well.

ubercart - 6.x-2.7
uc_vat - 6.x-1.2

Prices are entered without tax so on page admin/store/settings/taxes/vat the only things checked are 'Allow per line-item tax adjustments' and 'Use shipping line item settings from the tax rate config'

Example 1

• Show VAT amounts in separate columns at checkout unckeched
• Allow per line-item tax adjustments (requires patch to uc_taxes.module)

Added 1 item to basket (at sell price 19.90 ex VAT), shipping flat rate is 6.75 ex VAT...

cart/checkout:

Example2

• Show VAT amounts in separate columns at checkout CHECKED
• Allow per line-item tax adjustments (requires patch to uc_taxes.module)

Added 1 item to basket (at sell price 19.90 ex VAT), shipping flat rate is 6.75 ex VAT...

cart/checkout:

So the calculations in example 2 are correct when using the unpatched modules but using setting 'Show VAT amounts in separate columns'.

My client didn't want this setting. So I've used the patched file from #42 and everything is all good even without 'Show VAT amounts in separate columns '

So please commit #42 ASAP! And make this a critical update as this can cause big problems with the tax man!!!!

Cheers

In our case patch #19 at #1081130: VAT in invoice calculated on Total not subtotal (ubercart > 2.4) solved the issue for new and existing orders. But it's known not to work with all payment methods.