Replace php target selection with something better

The problem I'm running into when trying to solve this issue is that different entities have different primary keys to identify them. If you are rating a user you need $entity->uid and if you are rating a node you need $entity->nid and if you are rating a file you need $entity->fid, etc.

This is currently blocking my progress with #1198128: Convert fivestar/node_type pairings into fivestar field widgets

This may not be something better for target selection. However, what it does is to make fivestar fields default to voting on the entity to which they are attached.

It also allows you to vote on entities that are not nodes. Which I suppose is an improvement. So perhaps better target selection does apply.

I took a closer look at your first patch here, and I agree that it is the way to go. I rerolled your patch with some tweaks. It appears to work beautifully. But it revealed to me another issue.

I think that perhaps the voting target should be instance specific. This is due to the fact that the same field can be attached to multiple instances.

Here is the scenario:

1. I attach field_fivestar to comments on a specific content type and set it to target "Parent Node".
2. I attach the same field_fivestar to the content type itself and set it to target "Self"

I would expect that setting a vote in either location would cast a vote on the node. However, because the target is field and not instance specific, what I've done in step 2 is to retarget the comment votes at "Self".

I think that the best solution would be to change the voting target to be an instance setting in #1198128: Convert fivestar/node_type pairings into fivestar field widgets

I took your advice and have created separate patches that followed your order of updates.

1. #1205166: Field settings should be instance specific
2. #1173814: Replace php target selection with something better this issue
3. #1204350: fivestar_field_settings_form incorrectly sets the default value for stars
4. #1203428: Better Fivestar access check for the exposed field
5. #1198128: Convert fivestar/node_type pairings into fivestar field widgets

The patch for this issue does the following:

• Added a fivestar_get_targets function
• Implemented hook_fivestar_target_info for fivestar. This enables the "Self", "Reference node", and "Comment" options where applicable
• Added callbacks for each of the previously mentioned target options
• Replaced the PHP target section with the simple dropdown that reveals options described in hook_fivestar_target_info
• Altered _fivestar_field_helper and _fivestar_field_target to accommodate the new method of target selection. This enables voting on any entity type a field is attached to, not just nodes.

Latest patch is attached