Download & Extend
Views Slideshow » Issues

Custom template for views-slideshow.tpl.php fails: $skin and $slideshow lost

Posted by morningtime on May 31, 2011 at 7:05am
Project:Views Slideshow
Version:7.x-3.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Hi,

with views you can select under Theme Information the custom template file. I've copied the original views-slideshow.tpl.php to my custom views-slideshow--featured--pane-featured.tpl.php

It works after you flush the cache. But only once. If you refresh the page (F5), then you get these errors:

Notice: Undefined variable: skin in include() (line 16 of C:\Inetpub\wwwroot\123.com\sites\all\themes\andalusiah\templates\views-slideshow--featured--pane-featured.tpl.php). =>

> Notice: Undefined variable: slideshow in include() (line 24 of C:\Inetpub\wwwroot\123.com\sites\all\themes\andalusiah\templates\views-slideshow--featured--pane-featured.tpl.php). =>

The problem is that $skin and $template are no longer available in the custom tpl file. If you refresh caches one more time, again it works. But again only once - after you refresh the page again, same errors appear.

I'm showing this view as a content page within panels, but issue does not seem related to panels. It probably points to a tpl file caching issue.

Login or register to post comments

Comments

#1

Posted by morningtime on May 31, 2011 at 7:13am

I found a strange solution: copied the function template_preprocess_views_slideshow to my template.php ("mytheme_preprocess_views_slideshow"). Then the problem went away.

This shouldn't be necessary, should it? Why would it work after the first page-load, but not after that?

#2

Posted by jpstrikesback on June 21, 2011 at 11:38pm

I can confirm this whacky behaviour and the temp fix

#3

Posted by kruser on June 23, 2011 at 9:41pm

subscribing. same issue here.

#4

Posted by redndahead on June 24, 2011 at 6:23am

This may be a views issue. Views is what creates the theme function for that. Not sure what it may be on my side.

#5

Posted by redndahead on June 25, 2011 at 5:06am

Apparently drupal cannot handle preprocess files in theme.inc files. I'm working on it. Pretty much have to move the preprocesses to the .module file.

#6

Posted by redndahead on June 25, 2011 at 2:13pm
Status:active» fixed

This patch was committed.

AttachmentSize
1173910-d7-1.patch 10.97 KB

#7

Posted by System Message on July 9, 2011 at 2:21pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#8

Posted by youngelpaso on September 22, 2011 at 2:41pm

redndahead, where did you find the information about the theme.inc vs .module file?

#9

Posted by redndahead on September 22, 2011 at 5:08pm

I think crell told me in irc.

nobody click here