First of all I think the idea of this kind of cool and thank you for providing drupal community with it.

I cant help to wonder, is it really a good idea to rely on node.tpl.php when the module build the "all galleries" page? by calling node.tpl.php the module relying on theme to call pure print render($content); which is very rare in my opinion.

When a node.tpl.php uses a wrapper / complex html element to display for example submitted user picture for the node teaser then the custom / complex html element will be printed too along with the "galleries", thus there is a good chance it will break the "grid" layout. Not to mention if a certain module only print $content['body'] for the teaser part, this will break the layout too.

Wouldn't it be better if the module just do a node_load() and then theme the output via its own template tpl.php file after the variable preprocessed via template_preprocess function? That way any themer would just need to copy & edit the custom tpl.php if they want to change the layout / marking.

Cheers

Comments

lsolesen’s picture

Could you supply a patch which shows your proposed solution?

lsolesen’s picture

Status: Active » Closed (duplicate)

I see this as a duplicate of #1329350: Media display should be templated