Right now, _og_subgroups_prop_propagate_user_subscribe() defaults is_active for to 0 unless the group being subscribed to is OG_OPEN. IMHO, admins aught to choose whether or not propagated membership requires approval.

In my use case, group admins can join users to their groups via VBO and those memberships are propagated to children. I assume that active membership in the parent group means confirmed active membership in the propagated child groups too...but there's this annoying confirmation step. With a large tree, there's a bunch of confirming to do.

Seems like this would be a simple addition, but I wanted to check for community support before patching. Right now I have just hard-coded $is_active = 1 in _og_subgroups_prop_propagate_user_subscribe() line 128 of og_subgroups_prop.module.

Thanks!

Comments

bschilt’s picture

bschilt commented

The propagation module is designed to follow the access rules set up by the OG module. Switching your groups to be open would fix it, but you probably can't do that huh?

I think it would be a good idea to provide an admin override option on the settings page. There is already an Inheritance settings section where this checkbox can go.

submit a patch for review!

bschilt’s picture

bschilt commented

actually the checkbox should probably go on the propagation settings page in the user propagation section.

tbenice’s picture

tbenice commented

OK Will do.

Yea, it makes sense to follow OG access, but here's a special case where you want to keep groups' selectivity >1 so that requests for membership require review, but the admin can decide to allow propagated groups to become immediately active once the parent is approved.

Anyways, I'll submit a patch soon. Thanks!