Download & Extend
Simplenews » Issues

simplenews_get_user_subscription needed instead of simplenews_get_subscription

Posted by drpratten on February 11, 2007 at 6:51am
Project:Simplenews
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (duplicate)

Issue Summary

In function simplenews_subscription_manager_form()

    $subscription = simplenews_get_subscription($user->mail);

should probably be

    $subscription = simplenews_get_user_subscription($user->mail);
Login or register to post comments

Comments

#1

Posted by Sutharsan on February 13, 2007 at 1:04pm
Status:active» reviewed & tested by the community

Thanks for reporting this bug. I've tested the code as described it and made the patch.
This fix should also be applied to HEAD and 4-7--2 branch.

AttachmentSizeStatusTest resultOperations
simplenews.module_3.patch618 bytesIgnored: Check issue status.NoneNone

#2

Posted by Sutharsan on February 13, 2007 at 1:55pm
Status:reviewed & tested by the community» closed (duplicate)

I knew I saw this code before, and only after posting I kew: http://drupal.org/node/112191

I will close this patch since it introduces other problems with unsubscribed users using the path 'newsletter/subscriptions'. The above issues solves all.