I had some problems with the error message being an array sometimes in FeedsProcessor process method, attaching a little fix for it.

Also attached a fix for avoid calling twice getMessage in the exception.

CommentFileSizeAuthor
#1 feeds_message_error-1179936.patch1.01 KBpcambra

Comments

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new feeds_message_error-1179936.patch1.01 KB
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Needs work

You're just moving the call to drupal_set_message() down a few lines, I'm not sure how that avoids calling it twice?

The other bug has been fixed in #1149226: If log message is an array, feeds_log produces error: SQLSTATE[21S01].

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Needs work » Needs review

Well, it just avoids calling e->getMessage() twice by placing it in a variable, not sure if it makes sense. The main fix was the array thing.

emackn’s picture

emackn commented
Status: Needs review » Fixed

patch no longer viable. Fixed with #1149226: If log message is an array, feeds_log produces error: SQLSTATE[21S01] and #606612: More detailed log

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.