Closed (fixed)
Project:
Media Gallery
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
6 Jun 2011 at 23:52 UTC
Updated:
15 Nov 2011 at 04:52 UTC
Jump to comment: Most recent file
Comments
Comment #1
David_Rothstein commentedThat seems reasonable (at least it would make sure that people aren't running it with Media 7.x-1.0-beta3 or something).
But I'm not sure it would help with the main issue... if they try to run it with a Media development snapshot, would it still let it through? Do you know offhand? I'm guessing it probably would.
Comment #2
sylvain lecoy commentedok then if you want to block it for beta4 (no -dev)
It will then ensure the code is not compatible with a dev snapshot.
If you want more info: http://drupal.org/node/542202#dependencies
Comment #3
David_Rothstein commentedI did some testing, and it looks like if you use version dependencies at all (regardless of whether you specify the
>=or not), dev snapshots are always blocked. That's a little odd, but for our case I think it's what we want anyway.The attached patch updates the info files and README.txt for the releases that the next version of Media Gallery is expected to be compatible with. I think we should commit this patch right before Media Gallery 7.x-1.0-beta6 is released, and then roll it back after the release (so people can continue to use the dev snapshots with each other).
Hopefully this will help cut down on some of the bug reports and support requests :)
Comment #4
David_Rothstein commentedNew patch, with some additions from @effulgentsia originally written in another issue (forgot to mention the new Ctools dependency in the README.txt file).
Comment #5
David_Rothstein commentedCommitted this right before the 7.x-1.0-beta6 release, then rolled back the info file changes on the 7.x-1.x branch (so that dev versions of the various modules can still be tested against each other):
http://drupalcode.org/project/media_gallery.git/commit/d6d29ff
http://drupalcode.org/project/media_gallery.git/commit/5927ba3
Guess we'll see how it goes, and perhaps add something like it back to the info files right before the next (7.x-1.0-beta7?) release.
Comment #6
jamiecuthill commentedI'm having problems with the version dependency on media_gallery.
$ drush pm-enable -y media_gallery
Module media_gallery cannot be enabled because it depends on media (1.0-beta5) but 7.x-1.0-beta5 is available
$ cat ../../profiles/site_profile/modules/contrib/media/media.info | grep version
version = "7.x-1.0-beta5"
Any ideas?
Comment #7
elopio commentedSame problem here as #6.
Comment #8
dboulet commentedI had the same problem as in #6, enabling the module through the UI worked fine. Might be a Drush bug...
Comment #9
mrfelton commentedSame problem as #6. also works for me if done through the UI rather than drush.
Comment #10
geek-merlinconfirming #6.
as pointed out in #8 i would say this is a drush bug so marking as fixed and opened #1322532: drush pm-enable dependency resolution bug
Comment #11
mrfelton commentedNote: I had the same problem when trying to enable a Feature module that contained a dependency on media. The only way I can get the Feature enabled is through the Modules page (it doesn't work at /admin/structure/features, or through drush)
Comment #12
geek-merlinposted a fix at #1322532: drush pm-enable dependency resolution bug, maybe someone wanna review.
Comment #14
pitxels commentedIs this module compatible with media rc2 ?
It would be nice to have this dependency fixed as is seem to easy to fix.
Thanks
Comment #15
David_Rothstein commented@pitxels, have you looked at the README.txt file in the latest Media Gallery release? It says very clearly which versions of which modules this is compatible with. And it specifically mentions Media 7.x-1.0-rc2...