Link Mapper field name problem - Title overwrites url [#1181092]

Posted by dgdgdg on June 7, 2011 at 11:48am

10 followers

Issue Summary

There is a probelm with the link mapper.

When the field name contains 'url' (eg my field is field_url)

There is a test for 'url' against field_url:url and field_url:title ... both match against url and overwrite url subfield

fix as per the following code to run the test against $sub_field

FIX ... sorry not easy to get a patch right now

link.inc

function link_feeds_set_target($source, $entity, $target, $value) {
  if (empty($value)) {
    return;
  }

  // Handle non-multiple value fields.
  if (!is_array($value)) {
    $value = array($value);
  }

  // Iterate over all values.
  $i = 0;
  $info = field_info_field($target);
  list($field_name, $sub_field) = explode(':', $target);
  foreach ($value as $v) {
    if (!is_array($v) && !is_object($v)) {
      //if (strstr($target, 'url')) { DELETE
      if (strstr($sub_field, 'url')) { // NEW
        if(isset($entity->{$field_name}['und'][$i]['title'])) {
          $field['und'][$i]['title'] = $entity->{$field_name}['und'][$i]['title'];
        }
        $field['und'][$i]['url'] = $v;
      }
      //elseif (strstr($target, 'title')) {  DELETE
      elseif (strstr($sub_field, 'title')) { // NEW
        if(isset($entity->{$field_name}['und'][$i]['url'])) {
          $field['und'][$i]['url'] = $entity->{$field_name}['und'][$i]['url'];
        }
        $field['und'][$i]['title'] = $v;
      }
    }
    if ($info['cardinality'] == 1) {
      break;
    }
    $i++;
  }
  $entity->{$field_name} = $field;
}

Thanks

Comments

#1

Posted by Summit on November 11, 2011 at 12:20pm

Version:

7.x-2.0-alpha3

» 7.x-2.x-dev

Hi,

Thanks for the fix! I had exactly the same problem with latest 2.dev feeds. Can anyone please supply a patch for this. I am on travel, so no possibility for this. Thanks!
greetings, Martijn

#2

Posted by Johnny vd Laar on November 23, 2011 at 1:40pm

Status:

active

» reviewed & tested by the community

This works for me. Attached is the same fix as a patch

Attachment	Size	Status	Test result	Operations
feeds-link-title.patch	952 bytes	Ignored: Check issue status.	None	None

#3

Posted by twistor on December 20, 2011 at 8:23pm

Status:

reviewed & tested by the community

» needs work

This mapper needs a lot more work, but as far as this issue is concerned:

Why not just do, $sub_field == 'title'?

#4

Posted by emackn on December 21, 2011 at 4:47pm

Can you provide some setup to reproduce the error to verify the patch. I created a node type for the feed items with a field named 'field_text_url' and did not see the issue you describe. Also used the common syndication parser.

What might work best is an exported feature that recreates the setup for the feeds importer, its content type for the feed item and anything else that might help with this issue.

#5

Posted by twistor on December 21, 2011 at 8:41pm

Even better would be a test case that fails without the patch, and passes with it.

Alas, we can't, #1191330: Allow feeds_mapper.test to set field instance settings..

#6

Posted by tea.time on May 4, 2012 at 3:42pm

Version:

7.x-2.x-dev

» 7.x-2.0-alpha4

Ran into this exact problem just now...

@emackn - attached is a screenshot of the node processor's field mappings; the two denoted in red are the problem case. "External URL" is a Link field.

If the "Title" => "External URL Title" mapping is not set, then the "Item URL (link)" => "External URL URL" mapping works correctly, i.e. the feed item's URL gets saved into the URL portion of the Link type field.

But if the title mapping is set e.g. as shown in the screenshot, the feed item's title also gets wrongly saved into the URL portion of the Link field, rather than into the Title portion.