"Send to all affiliates" should allow any domain to be an option for domain source.

Currently this is not the case. You have to assign it to the domain you want to be a source.

However, if the node is assigned to the primary domain and its set "Send to all affiliates" then you can set the source domain to any.

I believe that if the content is set as "Send to all affiliates" then you should be allowed to set any of the affiliates as the source.

CommentFileSizeAuthor
#9 1181664-any-source.patch712 bytesagentrickard
#3 all_affiliate_sources-1181664-3.patch1.12 KBgrndlvl
#1 all_affiliate_sources-1181664-1.patch1.12 KBgrndlvl

Comments

grndlvl’s picture

grndlvl commented
StatusFileSize
new all_affiliate_sources-1181664-1.patch1.12 KB

Here is a patch for 7.x-2.x-dev.

If this has momentum I will create one for 7.x-3.x-dev as well.

Thanks,

Jonathan

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Needs review

It should apply to 7.x.3 first, actually.

Let the debate over this functionality begin.

grndlvl’s picture

grndlvl commented
Version: 7.x-2.x-dev » 7.x-3.x-dev
StatusFileSize
new all_affiliate_sources-1181664-3.patch1.12 KB

Yeah I know :( just I was being lazy as it was the version I was currently using.

So here it is as it should be for 7.x-3.x.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

I was thinking about it and would probably make this an option for Domain Source. Yet another setting.

grndlvl’s picture

grndlvl commented

I think you just like me going back and forth now. :p

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

I can add that, if we decide this is a reasonable feature. I'd like to know what others think at this point.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Anyone? Bueller?

grndlvl’s picture

grndlvl commented

I guess I stand alone on this one. :/

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 1181664-any-source.patch712 bytes

Actually, this patch should work for both 7.x.3 and 7.x.2.

If ($node->domain_site) is TRUE, then the node is assigned to all affiliates and no validation is required.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Reviewed & tested by the community » Needs review

Or should we check that the assignment has been selected as well?

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented

I am much interested in this. I will test the patch and report back

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

And I just had a client request it, so this gets in if the tests pass.

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented 
curl http://drupal.org/files/issues/1181664-any-source.patch | patch
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current   Dload  Upload   Total   Spent    Left  Speed
100   712  100   712    0     0   1339      0 --:--:-- --:--:-- --:--:--  3311
patching file domain_source.module

patch passes with no errors. no side effects to report yet.

---
EDIT: strange, hehe, http:// urls in -code- brackets get rendered as links here (look above ^^) ...

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Fixed

Committed to 7.x.3. I am not committing to 7.x.2, however, since this is a behavior change.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

pushpinderchauhan’s picture

pushpinderchauhan commented

Hi,

I am also facing this but with one more issue. I have described about my issue at following post, can somebody please look this post because I got stuck with this.

Domain Access : Unchecked Send to all affiliates option give Access Denied

Thanks