The fb_get_uid function can cause notices under certain circumstances, like if you send it an object that doesn't have a ->uid property.

CommentFileSizeAuthor
#4 fb-get-fbu-notices-1182218-4-no-prefix.patch764 bytesianthomas_uk
#1 fb-get-fbu-notices-1182218-no-prefix.patch708 bytessteven jones

Comments

steven jones’s picture

steven jones commented
Title: fb_get_uid can cause notices. » fb_get_fbu can cause notices.
Status: Active » Needs review
StatusFileSize
new fb-get-fbu-notices-1182218-no-prefix.patch708 bytes
socialnicheguru’s picture

socialnicheguru commented

error when I try to apply patch

git apply fb-get*patch
fatal: git diff header lacks filename information when removing 1 leading pathname components (line 5)

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented
Status: Needs review » Reviewed & tested by the community

This patch works for me

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented
StatusFileSize
new fb-get-fbu-notices-1182218-4-no-prefix.patch764 bytes

That patch no longer applies. This one should work against 7.x-3.3-beta3 at least, and hopefully -dev.

Dave Cohen’s picture

Dave Cohen commented
Status: Reviewed & tested by the community » Fixed

Thanks. Pushed to git.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.