It seems like this would be a simple fix, though. It appears that on the 'Order nodes' page, the protocol is hard-coded to http for the 'Save order' button. When my site's admin pages use HTTPS, this causes the 'Save order' button to result in a blank screen or Error 324 on Chrome, et al.

I suppose I could do some client-side scripting to change the protocol to match the page we're on, but this should be done in the module.

Comments

marcp’s picture

marcp commented

I don't have a site behind https handy right now to look at this. If you are able to supply a patch that'll work with both http and https I'd be glad to test and commit it.

mkoistinen’s picture

mkoistinen commented

I've inserted:

$form['#action'] = htmlentities("//" . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI']);

To the first line of the function nodeorder_form_alter() and it appears to solve my immediate issue. However, I'm not familiar enough with the Nodeorder code to know if this is the right solution in all cases.

Basically, I'm just telling the form to go to itself using a protocol-independent URI: (http://paulirish.com/2010/the-protocol-relative-url/)

And, it works for me. Please do test though, I'm not sure if all uses of the function nodeorder_form_alter will require the form to go to the same URL that it is currently on (although, I see nothing suggesting that another URL would ever get used).

dieuwe’s picture

dieuwe
Location Auckland, NZ
commented
Issue summary: View changes
Status: Active » Closed (outdated)

Closing as the Drupal 6 branch of this module (and Drupal 6 in general) has been discontinued.