Hi there. This is my first post here on Drupal.org. Since my PHP knowledge is still coming along, I have been unable to get-to-grips with Revisioning to add this feature myself, so here is my request:
1. At node/%/revisions or node/%/revisions/list, option Delete all % revisions should be Delete content.
2. There should be an option available to delete all non-current/archived revisions.
Number 1 is to avoid confusion with the current Delete all % revisions option as without checking the resulting page (node/%/delete), one can assume the current revision will not be deleted.
Number 2 is to assist in house-keeping where deleting each revision individually is an unnecessary chore.
As an added extra, may I kindly ask to be pointed to where Revisioning adds the Unpublish current revision | Delete all 5 revisions links to node/%/revisions?
Regards,
Henry Blyth
Comments
Comment #1
rdeboerHello Henry and may I welcome you to the Drupal forum as the first receiver of your post!
First of all thanks for the detailed description and use of italic and bold fonts. Most feature requests aren't this clearly formulated and formatted and I sometimes waste time trying to understand what people want to say. Not in your case.
As for your issue, I agree on both counts.
1. Not being a native English speaker I've been thinking about the right label for the "Delete all % revisions" button too. I wanted to make it clear that it didn't just mean, "delete a revision". "Delete content" is good. Would "Delete all this content" be over the top? "Delete content (% revisions)", maybe?
2. I've been thinking of putting in a "Delete archived revisions" option myself -- I don't think we'd want to include pending revisions in that delete operation, do you?
As an added extra, here's the answer to your final question. These links are added by
function _revisioning_generate_node_links_according_to_permissions(), file revisioning_theme.inc. This function is called fromfunction theme_revisioning_revisions_summary(), which is in the same file. That function passes, indirectly, the revision summary table and the links above it to therevisions-summary.tpl.phptemplate for final rendering.Drupal's theming engine is a topic in itself, but I hope this helps you on the road to exploring PHP and Drupal further!
Rik
Comment #2
johnpitcairn commentedMy recommendation would be simply:
Unpublish/publish current | Delete archived | Delete all
Some of my users are not very clear on what a "revision" is, and tend to assume that the published revision is not a revision. Just use the terms that are already applied to each item, don't confuse them by making them think about revisions, since everything in the table is a revision anyway and the title clearly states "revisions for xxx".
I think "delete content" would be more confusing, because the term "content" is not used anywhere in that table. I know at least some of my users will take that to mean "delete all content", for the whole site!
Comment #3
rdeboerThank you both for your insights...
Decisions, decisions...
Comment #4
Taxoman commented+1
Comment #5
rdeboerImplemented and checked into repository, master branch.
Will be available in next release, 7.x-1.1
Comment #6
johnpitcairn commentedCheers for that. What are the chances of a backport to 6.x?
Comment #7
rdeboer@John Pitcairn, #6:
That should be fairly straightforward....
But time is precious...
Comment #8
johnpitcairn commentedOf course. I nostly want it for my own management rather than for my clients to use, so I have no budget at present, but if one of them requests it I'll happily take a look at a backport myself, and provide a patch if so.
Comment #9
rdeboerI will probably have some time next week to backport a couple of D7 goodies to D6. But no firm guarantee...
Comment #11
rdeboerAvailable in 6.x-3.13 and 7.x-1.2
Comment #12
marcoBauli commentedEDIT: works as expected
Comment #13
marcoBauli commented