Module short names (or system names or machine names) should be lowercase, and we shouldn't allow people to create/promote full projects while violating this convention.
This is documented for both Drupal 6.x and for 7.x: "This short name will be used in all file and function names in your module, so it must start with a letter and by Drupal convention it must contain only lower-case letters and underscores."
(Having mixed-case names also causes problems with update functions #200628: Problem with update of mixed case module names and reasonable usage of Drush #1189178: Capital letters in machine name confuses Drush (and me).)
This task will affect this issue as well and is part of the D.O. upgrade from 6 to 7 (Convert project URLs to lower case.) : #1189292: Let enforce lower case names for new projects
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 0001-Issue-1189292-Let-enforce-lower-case-names-for-new-p.patch | 2.05 KB | marvil07 |
| #5 | mixed_case_module_list.txt | 3.49 KB | redhatmatt |
Comments
Comment #1
mlncn commentedMoving from the Drupal.org infrastructure queue to Project module, per advice in #drupal-infrastructure. Would this have to be drupal.org specific or can this be assumed a sanity check on any (Git) project?
Comment #2
dwwThis seems a bit close to a d.o-only hack. However, I can see other reasons you might want to force lowercase shortnames (e.g. you want to keep all your URLs lowercase, so you don't want project/CamelCaseSucks aliases). I guess a single checkbox for "Require lowercase project short names" at admin/project/project-settings would work, and we've already got a special function directly in project.module just for validating this field (since there are already a lot of things we're checking for, and we need to validate it in a few different places):
project_validate_project_shortname()
So sure, patches welcome there (along with project_settings_form() for the checkbox).
Thanks,
-Derek
Comment #3
senpai commentedTagging for the D7 upgrade initiative.
Comment #4
redhatmatt commentedTwo MAIN items to address and estimate time on:
(Having mixed-case names also causes problems with update functions [#200628]: Problem with update of mixed case module names this problem seems complete from what I've read and simply needs review which I will do: 2hr
-- and one more issue as far as how to "take care" aka update Drush and it's release xml after all of this is done. #200628: Problem with update of mixed case module names
Comment #5
redhatmatt commentedComment #6
redhatmatt commentedAdded actual task to change URLs to lower case: #1832934: Convert all URLs to all lowercase.
Comment #7
redhatmatt commentedReducing estimate to zero as there are three other issues covering this and estimated: #1832934: Convert all URLs to all lowercase., #1189178: Capital letters in machine name confuses Drush (and me), #200628: Problem with update of mixed case module names
Comment #8
dwwTeaching redhatmatt the joys of the issue filter... If you type this:
You get this automagically:
#1832934: Convert all URLs to all lowercase.
#1189178: Capital letters in machine name confuses Drush (and me)
#200628: Problem with update of mixed case module names
And if you want to refer to a specific comment in an issue, like comment #5, you just do this:
#200628-5: Problem with update of mixed case module namesand you get this:
#200628-5: Problem with update of mixed case module names
Slick, huh? ;) Much more useful...
Thanks,
-Derek
Comment #8.0
dwwReferencing relevant cross task URL: Convert project URLs to lower case. https://drupal.org/node/1832934
Comment #9
marvil07 commentedComment #11
marvil07 commentedComment #12
drummCommitted!
Comment #13.0
(not verified) commentedadded proper url