Split up PayPal WPS/WPP/Express options in a more intuitive manner

Changing this to a task.

Weak dependency on #1226602: Allow express payment (PayPal/Google) to be enabled directly in payment method settings

I think the settings should be duplicated as necessary for each method, as that will make it easier to configure, and also will let store owners use different PayPal accounts for the different methods if needed.

PayPal EC is tied to WPP, not WPS. You must have a WPP account in order to use EC, and you must make EC available when you use WPP (according to PayPal TOS). The credentials are the same for EC and WPP.

Attached patch moves all settings to the EC form, then reuses a subset of them for the WPP form. Needs testing.

>PayPal EC is tied to WPP, not WPS.

TR are you sure? I use PP EC with out using WPP. I just enter my api info into the PPEC form fields under WPP settings page. This allows me to have a much cleaner checkout process then with the WPS checkout way. I do have to use CSS to hide the Express Checkout button.

I'll get some screen shots later.

@future assassin: Well, I *was* sure, based on when I last did some PayPal integration a few years ago, but it looks like some of what I said in #4 not true any more. Specifically, it does appear you can use EC without WPP or WPS. But it's still the case that if you use WPP you are obligated to use EC as well. Here are some references:

https://cms.paypal.com/us/cgi-bin/?cmd=_render-content&content_ID=develo...
https://cms.paypal.com/us/cgi-bin/?cmd=_render-content&content_ID=develo...

I'll read through that tonight. I'm not sure when I used the EC info only in the UC WPP setting but its been at least 1.5 years since the first time I tried that. I was confused a little as I just tried it on a whim and it worked.

If you test it out you'll see that it does the following (I included screenshots)

Customer clicks check out
Customer is taken to a UC page where they select their info and shipping options.
Customer is taken to paypal were they see a summary and enter their CC details
Customer is then taken back to the UC review page where the customer click submit
Customer is taken the a thank you page on the UC site.

Hm. So Express Checkout can be invoked from the cart page, or the checkout page. I think #1226602: Allow express payment (PayPal/Google) to be enabled directly in payment method settings removed the ability to show EC as a payment method at checkout. This means we need a new option somewhere, to control whether EC appears on cart, checkout or both.

Committed. I will reopen the other issue, as that means that EC can't be used as a payment method any more, which I didn't realise was possible before.

>which I didn't realise was possible before

I don' t think many people knew this but it is a huge step forward compared to the regular WPS checkout process.

Any info getting EC to work like I have here http://drupal.org/node/1190744#comment-4785784 on D6/UC2. I just tried it on the latest D7/UC3 and I can only make it work by unchecking the Enable Checkjout box other wise I get Illegal choice in Payment method element

I can use WPS for now as its working good and seems a little cleaner than in UC2 but the above EC checkout was pretty nice.

#1226602: Allow express payment (PayPal/Google) to be enabled directly in payment method settings is the issue where that will be fixed.

Reopening for 6.x as Express Checkout options are hidden under PayPal WPP settings, which are not visible if uc_credit is not installed.

Reference: http://www.ubercart.org/forum/ideas_and_suggestions/29977/how_disable_re...

This is definitely needed as the admin interface is monumentally confusing.

Not worth changing this in 6.x now.