Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.it actually gets cloned but the original node does not have those images anymore (you have to upload them again)
is that a bug or by design ?
using drupal5.1 and latest CCK and node_clone
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | clone_permitted_DRUPAL-5_4.patch | 3.2 KB | pwolanin |
| #9 | clone_permitted_DRUPAL-5_3.patch | 3 KB | pwolanin |
| #8 | clone_permitted_3.patch | 2.98 KB | pwolanin |
| #7 | clone_permitted_2.patch | 2.95 KB | pwolanin |
| #5 | clone_permitted_1.patch | 2.64 KB | pwolanin |
Comments
Comment #1
pwolanin commentedThis module does not take any special account of CCK, it just calls core API functions.
In general (because of how uploaded files are handled - each associated with a single node) it can't really work well with file/image attachments without specialized code.
Try this patch: http://drupal.org/node/110294#comment-197033
The alternate method of cloning seems to work better for some in terms of uploaded files.
Comment #2
giorgoskThanks pwolanin
so this is turn into a feature request for the node_clone
Comment #3
moshe weitzman commentedi would like to be able to not ofer cloning on certain node types - the ones that always use imagefield in my case.
Comment #4
pwolanin commented@Moshe- that seems like a reasonable work-around for problematic node type. I'll look into it.
Comment #5
pwolanin commentedAttached patch is against the DRUPAL-5--2 branch for this module. Follows more or less the template in og.module.
Comment #6
moshe weitzman commentedcode looks sane to me. i think you can compact a bit with node_get_types('names'); which returns an array suitable for form options. also, you have a type - search for 'ehre'
Comment #7
pwolanin commentedOk, I think this is good to go.
@Moshe - which branch of the module are you using? Also, I noticed a bug, of sorts, in OG where you must exclude at least one node type from the "Audience targetting system. " (also a typo there). Maybe you can use the same method for OG (patch to follow)?
Comment #8
pwolanin commentedsee issue w/ patch for og: http://drupal.org/node/141491
Also, in this patch changed "None" to "none" per core usage.
Comment #9
pwolanin commentedAlso a patch for the DRUPAL-5 branch
Comment #10
pwolanin commentedonce more with capitilization fix too.
Comment #11
moshe weitzman commentedi am using DRUPAL-5 branch.
i will look into the og issue.
Comment #12
pwolanin commentedOk, the last relevant patches committed to both the DRUPAL-5 and DRUPAL-5--2 branches.
@Moshe - I'd appreciate if you have time if you could look at this latter branch- the module works by a very different mechanism. It just populates the node form rather than using node_save(). I'm thinking about making this the default download.
Comment #13
(not verified) commented