Moderators can only view pending revisions if they are given the "Bypass content access control" permission.

This is certainly not the way it should be and I cannot reproduce it.

All the moderator should need to view and edit pending revisions are the "View content revisions" and "Edit content revisions", "... edit content" permissions (optionally for the content types in question only).
You should not need "Bypass content access control" -- in fact I strongly advise to switch that permission off for all roles.

Did you follow these instructions: http://drupal.org/node/408968 ?

If after following the above instructions you still have problems you please tell us the permissions you have set and not set? Or send a screenshot of the admin/people/permissions/permissions page?

Hi dixhuit,
Thanks for the screenshot.
Which role from your screenshot in particular has the problems you describe?
Rik

Hi dixhuit,
Phew! So glad you said that.... I was thinking my module was all to blame.
I think you are right in suspecting some module interference.... I do not wish to point a finger, but as the issue seems to be about access to content, I may want to suggest to look for modules that affect permissions.....
I had a look at your permissions screen shot but nothing jumps out. I don't know much about the UR module.
Suggest you also compare and contrast what happens when you are logged in as a Moderator vs super-admin (uid=1) vs "just any plain authenticated user"?
I'm sorry, I wish I could help more, but I feel you are already on the right path with your analysis.
Good luck -- please let us (the community) know if you find out what's wrong...
Cheers,
Rik

Ok all good.
Sad to lose you to Workbench Mod though... Do you really feel it does a better job?

No probs.
Good luck!
You're always welcome back!

I see the exact same problem But I have no panels installed, So the conclusion is probably wrong.
I have given my moderator any reasonable prmision, but only when adding the "Bypass content access control" permission. the pending menu is shown.
My Drupal is 7.7 and revision is in version 7.x.1.2

So I ask this bug is reopened.
Let me know what info will help you

@Martin Hansen, #11:

Sorry for being so late in getting back to you. I have just applied a couple of patches to the 7.x-1.x-dev version that deal with permissions.
Could you be so kind and try to reproduce your issue and if it still exists clearly write down the steps to reproduce it, please?

Thanks in advance!
Rik

I updated to the Dec 19 Dev release and still have this same issue. It is "fixed" temporarily with a "Rebuild Permissions" but then it doesn't show any new content awaiting revision.

Bypass Content Access Control does solve the problem (at least for now), but I'd rather not have "editors" with this sort of power.

Thanks PoetCSW,

When you say "It is "fixed" temporarily with a "Rebuild Permissions"", what is it that causes it to be broken again? When you edit the node in question? Or publish/unpublish it perhaps?

I am looking into this again. In the mean time... there must be one or more modules on your system that deal with access control. Any idea which ones?
What happens if you temporarily disable these one by one?
Rik

@PoetCSW, #13,14
To help us identify which content access modules are in play on your system, I added an "Additional Info" section to the bottom of the Configuration >> Revisioning page.
Could you please try the development release 7.x-1.x-dev (once auto-generated by the system, should be dated 22 Dec or later, or check out from Git) and report what it says on your system in this new "Additional Info" box?

RdeBoer:

Sorry, I was away for the holidays. Yes, there is an ACL manager: Content Access 7.x-1.2-beta1

We use it to prevent some users from accessing some "books" and "articles" that contain internal procedure manuals. I wish I could create a content type that behaved just like "book" -- that would solve my problem and avoid the need for Content Access. I've created a number of content types to control what users can / cannot see, but "book" outlines are special.

I'll research the possibility of alternatives to Content Access. For now, I gave "Bypass Access Control" to all editors.

@PoetCSW:
So I've enabled Content Access 7.x-1.2-beta1 (but not the submodule "Content Access Rules Integrations").
http://drupal.org/project/acl not installed.

I can't see anything obvious going wrong on my system....
Any chance of some hints towards a simple reproduceable test-case?
Rik

RdeBoer -

Today I have something else strange happening - Published items are getting "access denied" messages for visitors (not authenticated users). I'm swamped with work, so I'll have to test this tomorrow, but it is a new issue with no changed to the system. I didn't even know there was a problem because I'm tackling too many projects.

When I disable Content Access, the problems do seem to go away, but I need to restrict some books.

- CSW

Look forward to your report. Am keen to sort this one out.
Rik

Okay, I received an email from the non-profit I'm helping indicating edited content from 23 Dec 2011 to the present is receiving "Access Denied" messages. I'm going to check all modules repair permissions tonight. Because I'm trying to prepare for next semester (I'm a prof at university), I'm not sure when I'll have time to trace the various issues. I'll let you know what happens, though.

- C. S.

Okay, I've pinpointed the issue, it seems. If I disable the module Content Access 7.x, the system works perfectly -- but with the downside of allowing everyone to access "member only" books and other restricted content. I wish I could create a new content type that worked like "Book" but had new security settings. That would solve the issue for us.

Anyway, Content Access is definitely the complication.

Not sure how to push this further.
What worries me too as I went through the Content Access configuration is this message from Content Access:
"Warning: Your content is not published, so this settings are not taken into account as long as the content remains unpublished."
This is rather old school, i.e. D6. In D7 permissions can be more refined.

I believe I'm having the same problem with 6.x-3.13. I've turned off any content access related modules and rebuilt permissions and still get the Access Denied error. It was working before the update.

Also, upgrading to -dev didn't help and I should mention that there is no "bypass content access control" permission in d6 that I can find so I am currently unable to see revisions.

And uid=1 is denied access.

Hi peggysmouse,

If uid=1 is denied access then there's something seriously wrong on your system.
Have you installed Module Grants, which I highly recommend. If so, have a look at its configuration page, where it lists all access control modules on your system. If it says none, then you must have some other module that screws things up.
Did you follow these instructions: http://drupal.org/node/408968 ?

BTW, re #24, the near-equivalent of D7's "bypass content access control" is "administer nodes" in D6.

Rik

Hi Rik,

Module Grants is installed. It doesn't list any AC modules on it's config page. I had Protected Node and Workflow Access installed but disabled both and rebuilt permissions with no change. The Content Access module itself is not turned on although it was at some point last year. I have rebuilt permissions since turning it off. I do have the Administer Nodes permission and obviously UID=1 does so no joy there.

I believe I have configured the site according to the instructions you list above.

Is this a new issue?

PM.

So sorry PM,
Yes this is new, as I don't think Revisioning would have 4,000 installs if a lot of them experienced what you're seeing....
I don't know what to suggest. Panel Node permissions (if you have Panels installed, reported above in #7).
Run /update.php, just in case. Clear caches...
Clutching at straws...
Rik

Same problem here.

The moderators cant see "Revisioning Pending" unless point bypass all permissions.

No minipanels installed.

The curious is "Pending Revisions Block" works good for moderators, but they cant use views page.

Any new on this?

I try developing version too and nothing.

Sorry for my english :P

Same problem for me:
I test Revisioning with a clean Drupal instance. It works well without Content Access module but when I enable it, I see (with Devel node access) that moderators can update node but no view them.

Cedric

Happy to reopen this, only to comment that a reproduceable test case (as its own issue) would be much appreciated.

Going through this thread there seem to be three variations sharing the same symptoms but no one has provided clear steps on how to reproduce them:

1) Panel Node permissions: solved in #7
2) Content Access module enabled (#21, #31)
3) Revisioning 6.x-3.13 without any content access modules enabled. Cannot even see revisions as uid=1 (#27)

It would be great for all of us if the reporters of issues 2) and 3) could write down the steps of where what's going wrong on their system and open a NEW issue for this as this thread has become very confusing.

Rik

Hi Rik,
If you want to contact me privately, I will give you access to a dev site which has issue #3.
PM.

@peggysmouse:
I had a look on your site and while I don't have access to peek in you database, I was able to reproduce the same symptoms on my test system.

1) You have the Diff 6.x-2.3 module installed. That in itself is ok, but:
2) Somehow you or some piece of code in some other module has increased the so-called "weight" of the Diff module to be greater than that of the Revisioning module. Therefore the Diff module is undoing Revisioning work on URLs of the form node/921/revisions/2703/view.

Using something like phpMyAdmin I suggest you execute the following SQL:

UPDATE system SET weight=0 WHERE name='diff';

And for good measure:

UPDATE system SET weight=0 WHERE name='revisioning';

After this you'll have to clear the caches at Site configuration >> Performance for the db changes to become effective.
I believe that will do the trick. Let us know how you went.

Thanks so much Rik!

On the live site, I reset the weight of Diff from 1 to 0 and turned off Smart Tabs (and Module Grants Monitor) and everything else works as advertised. I'm not sure how the Diff weight became 1. I don't think I did that. Perhaps there was an update by the module?

Smart Tabs is still causing other redirection issues, even with Diff turned off and all the other changes in place. I'll file a bug there.

PM

Great to hear that PM!

So this means in this thread we only have one real issue left "Content Access module enabled (#21, #31)".

Closing this issue as it has become convoluted.

If you have a problem similar to this, please raise a new issue, with clear steps on how to reproduce it.

Typo