various bugs with video update

we have back-ported the ver 5 video module to 4.7 and things seem to more or less work correctly.. but very little seems to work correctly when "Editing" (i.e. updating) an image.

perhaps someone can let me know if this works for 5 as perhaps there are some fundamental deltas between 4.7.5 and 5.0 that are getting in the way here... or just bugs in video module???

this is what i see when trying to upload a replacement video (i.e. edit existing video node):

- thumbnail does not get created:

near top of _video_ffmpeg_helper_auto_thumbnail() in ffmpeg helper module there is the following code:

if (empty($_SESSION['video_upload_file']) || !$_SESSION['video_upload_file']->newfile || $node->iid || $_SESSION['video_upload_file']->iid || $_SESSION['video_upload_file']->thumbnailed) {

   dont make thumbnail 

}

on edit.. $node->iid does exist so this will always fail. I removed it and now thumbnails get created.

BUT:

- thumbnail gets created as a new image... as opposed to replacing old image.
--- when i look at the code in video_image there is only a submit op in the nodeapi.. so pretty hard to think this wil ever get done right???

- updates are also done done to the video table or video render table - even though the new video does actually get uploaded to video folder

so.. basically.. nothing works

so is this for real.. how could it be no one else has seen this??? is drupal 5 magically combining submit/update/insert ops to make this all work out in 5 but not 4.7? Sorry , not very 5 happy yet.

I will be starting to fix this mess.. but just wanted to make sure it wasnt alerady working and i was just missing the point somewhere..

Peter Lindstrom
LiquidCMS - Content Management Solution Experts