Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Hello Gibus,
On the priorities/priorities-survey_name page the title of the survey is displayed twice. Is this by design or shouldn't we remove this extra line $output = '<h2>' . $survey['title'] . '</h2>' in line 905?
Regards,
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | priorities_pushbutton.png | 10.86 KB | ec |
| #5 | priorities_bluemarine.png | 5.91 KB | ec |
| #3 | priorities_duplicate_title.png | 12.11 KB | ec |
Comments
Comment #1
gibus commentedIt is by design. If you have the title twice it is because your theme display it in the first place. But we cannot assume that every theme will do so. Actually we behave just like a node page in most themes which displays the title in
<h2>tags.Comment #2
ec commentedHi,
I'm using mix and match a Fusion based theme. And I currently run with some issues when using "priorities" module.
Thanks,
Comment #3
ec commentedGibus,
Sorry, but I just give it a try with a stock Garland and found the same issue (please, look at the screenshot attached)! Any idea about this?
Regards,
Comment #4
gibus commentedOK Eric, what you can do is define your own theme function (in template.php of your theme) :
yourthemename_priorities_surveysby copying the originaltheme_priorities_surveysfrom the priorities module and delete the<h2>display in your theme function.Comment #5
ec commentedGibus, sorry to be that "heavy" on this issue, though I may miss one thing here. The title is displayed twice on every stock theme sent with a stock drupal. See as samples the screenshots attached for "pushbutton" and "bluemarine". Hence are you saying that this is a normal behaviour? Obviously I can comment the line in the priorities module, though this sound a bit strange and new users may not understand this behaviour. Any thought?
Comment #6
gibus commentedDo not modify the module. This is a themable function, therefore you can copy it in your theme and modify what you want in this copy.
Comment #7
ec commentedYes I know I shouldn't modify the module. Though what I don't understand yet (but may be it's myself) is why the default behaviour of this module with standard drupal themes (garland, pushbutton etc.) is to duplicate a title??? And hence why should I (and all new users will have to do the same) have to modify a standard drupal theme to have something play nicely with it? I still can't understand your statement in #1, what are those
which do not behave like standard drupal themes?
Comment #8
gibus commentedI'm really confused Eric, I've mixed two instances in priorities module source code where
<h2>tag is used and so far I was talking about the wrong location (near line 1261). Therefore I've fixed and commited the good location you were talking about.Thx very much for helping to improve this module, you deserve a new release including both minor fixes you've helped to implement: http://drupal.org/node/1198852
Comment #9
ec commentedWell, this demonstrates that it is not always easy to collaborate when were are all behind a keyboard only ;-). Anyway, thank you for committing. And I'm happy that I was not wrong to be so insistent! By the way, I'm trying out this interesting module to see if it cando the job for my use case. I still have some minor issues to report, though I want to be sure before posting ;-) I may also have some features to suggest... Regards,