Download & Extend

Potential JS Conflict for inactive icons on admin page

Project:SexyBookmarks
Version:6.x-2.0
Component:Code
Category:bug report
Priority:normal
Assigned:Shocker88
Status:reviewed & tested by the community

Issue Summary

Re: my investigation into the issue users were reporting on dragging active->inactive (#1184826: Dragging Active - Inactive Doesn't Work) I ran into what looks to be an unrelated (somewhat minor), but a little confusing bug. If Sexybookmarks are active on the modules admin pages (siteurl.com/admin/settings/sexybookmarks*), the external JS called to display the appropriate icons there actually hides all of the inactive icons. Rendering the admin interface pretty unusable!

Looks unrelated to the other issue since it doesn't break JS just hides all inactives. But I'll link to this one from there just in case since it looks like people in that issue have a few different similar problems (likely site-specific...

I've done up a quick patch and attached it here, which rectifies the issue and I don't believe would have any ramifications - believe it's good to be applied to sites but would appreciate someone reviewing as I'm still learning drupal best practice etc :)

AttachmentSize
admin-bug-patch.patch1.25 KB

Comments

#1

Status:needs review» reviewed & tested by the community

patch works as advirtised.

#2

Cheers for review and sorry for my slow response. Would be good to see this implemented into the module to ensure people don't hit the wierd issue that can be caused otherwise, but far from a priority item!