Titles and descriptions are not shown on most elements that are altered by IFE.
By setting #theme_wrappers on elements at the form_alter stage, default #theme_wrappers for those elements are not loaded. Most elements need the form_element wrapper which adds the title & description.

The attached patch adds IFE's theme wrapper at the pre_render stage, at which point the default theme wrappers will have been added.

I attach two patches - the standard one that has gone through format-patch, and a simple one (using --no-prefix) that is compatible with Drush.

CommentFileSizeAuthor
#5 themewrappers-and-d7-elements-1202554-5-no-prefix.patch (Drush compatible)4.98 KBjames.williams
#5 themewrappers-and-d7-elements-1202554-5.patch5.53 KBjames.williams
#3 themewrappers-and-d7-elements-1202554-3.patch5.22 KBjames.williams
#3 themewrappers-and-d7-elements-1202554-3-no-prefix.patch (Drush compatible)4.7 KBjames.williams
#2 themewrappers-and-d7-elements-1202554-2.patch4.57 KBjames.williams
#2 themewrappers-and-d7-elements-1202554-2-no-prefix.patch (Drush compatible)4.08 KBjames.williams
ife-default-theme-wrappers-no-prefix.patch (Drush compatible)1 KBjames.williams
ife-default-theme-wrappers.patch1.95 KBjames.williams

Comments

james.williams’s picture

james.williams
Location Coventry, UK
commented

Ah - I just noticed that doesn't work with the checkboxes/radios types. I'll do some more testing/fixing & do another patch, sorry!

james.williams’s picture

james.williams
Location Coventry, UK
commented
StatusFileSize
new themewrappers-and-d7-elements-1202554-2-no-prefix.patch (Drush compatible)4.08 KB
new themewrappers-and-d7-elements-1202554-2.patch4.57 KB

Okay this is better - I've tested the attached patch with all standard core D7 form elements and wrappers (i.e. containers as well as fieldsets), and added some special handling of text_format elements (these don't work correctly otherwise).

The problem with my approach in the initial patch just replicated the problem with default theme_wrappers for default pre_render functions instead!

There was a change to form_get_errors() in D7, which caused some different behaviour - I've fixed that too. So this patch effectively finishes porting this module to D7. I hope!

james.williams’s picture

james.williams
Location Coventry, UK
commented
StatusFileSize
new themewrappers-and-d7-elements-1202554-3-no-prefix.patch (Drush compatible)4.7 KB
new themewrappers-and-d7-elements-1202554-3.patch5.22 KB

Finally, this patch includes all of the above, but also updates the support for contrib field types. Old CCK element types that don't get used any more have been removed, I've updated support for the various element types provided by Date & Link module, and sneakily added support for webform's element types too :-)

I hope this is helpful!

stijndm’s picture

stijndm commented

Hi James, this all sounds good. I'll have a look as soon as possible.

I'm currently looking in to ways of getting rid of the ife_field_types() so all elements are supported automatically, so I'm not sure what I'll do with that.

james.williams’s picture

james.williams
Location Coventry, UK
commented
StatusFileSize
new themewrappers-and-d7-elements-1202554-5.patch5.53 KB
new themewrappers-and-d7-elements-1202554-5-no-prefix.patch (Drush compatible)4.98 KB

Cool, glad to know I'm not only one who will find it useful :-)

I've just discovered two more issues with the latest patch - this one now adds support for elements within any other element (i.e. not just fieldsets & containers -- for example, webform module can put things within 'value' elements), and the renamed user_register_form default.

davidwhthomas’s picture

davidwhthomas commented
Status: Needs review » Reviewed & tested by the community

+1 to the above patch in #5, fixed the issue with IFE not working on user profile forms and got the errors showing in the correct place inline, with thanks.

DT

james.williams’s picture

james.williams
Location Coventry, UK
commented

:-)

himerus’s picture

himerus commented

+1 for this patch.

rdeboer’s picture

rdeboer
Location Melbourne
commented

For those not comfortable with applying patches see #1480074: Accessibility feature: change errors at top to links clicking through to the form error element for a downloadable tar bal (i.e. ife.tgz) that also includes an additional feature.

ipwa’s picture

ipwa commented

+1 Patch worked for me.

stijndm’s picture

stijndm commented
Status: Reviewed & tested by the community » Fixed

I have no idea why this has been in the queue for so long. All code is now commited to dev. I split the patch into several commits as it addresses several unrelated issues.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.