Closed (fixed)
Project:
Fivestar
Version:
7.x-2.x-dev
Component:
Code
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
29 Jun 2011 at 02:53 UTC
Updated:
31 Jan 2012 at 22:43 UTC
Jump to comment: Most recent file
Is there anyone that uses the fivestar color picker?
Is a great feature, but there's too much there to maintain. I want to know if these feature is being used. If not I think we should remove it.
We can always set up a separate site that allows you to create the stars and download them to your server or maybe create a star that can be changed with css, etc.
We'll see if we get any replies. If not we'll probably remove it.
Thanks.
Comments
Comment #1
james.elliott commentedComment #2
james.elliott commentedI should say, here is the patch to remove the color picker assuming there is no interest expressed.
Comment #3
ericduran commentedyea,
I think this should go. If anything we can have a fivestar_extra module that add this functionality back, but I really don't want to support this on the fivestar core module. I don't think is used that often. I'll wait a little longer see if anyone actually disagrees with me, if now we'll drop it.
Thanks for the patch.
Comment #4
cliff@ericduran, I'm just now downloading fivestar to test on a conference website. We'll (try to) use it to create a rating system for reviewing proposed sessions. (This isn't an unconference; it has blind reviews, sometimes suggests proposers change the format of a session to get it accepted, the whole bit.)
Get me up to speed, please: Exactly what purpose does the color picker serve?
Comment #5
ericduran commented@cliff, The color picker is only the for when people want to configure the color of the stars. The problem is that only a couple of the stars are actually configurable. Thats about it.
This is a great feature that can live either on another module or on a website which would let you configure the colors of yours stars then allow you to downloaded them on your website. But thats about it.
Comment #6
james.elliott commentedAttaching latest patch. I found some more color related loose ends.
Comment #7
Alphabool commentedIf the proposal is to remove the widget that allows you to specify colors by clicking on the color wheel/gradient, then no, I don't use that. However, if the proposal is to remove the entire 'color scheme' options, I don't support that because I really want to be able to customize the colors of my stars. However, I'm having trouble getting it to work on the 7.x-2.x-dev branch; I can change the colors in the configuration form but on nodes the voting widget's colors don't change, even after clearing Drupal cache and browser cache.
Comment #8
ericduran commentedThis is to remove the entire color picker and color scheme.
I'm very tempted to remove all this, I don't think the use is that great and its just a lot of extra code to maintain. I'm going to try and maybe separate it out into an extra module or something.
We can start a fivestar_extra that contains some of the functionality that really doesn't belong in fivestar.
Comment #9
Alphabool commentedTo be honest I could never get it to work and so ended up overriding it in my CSS, so it was of no use to me.
Comment #10
ericduran commentedHmm, I'm so tempted to just rip this out. I'll see if I can roll it into a separate module, it its possible then I'm going to rip it out.
I'm going to switch to this a task in case anyone else wants to give it a shot.
Comment #11
ericduran commentedComment #12
ericduran commentedThis got committed in with a different patch.
Comment #14
Marc Bijl commentedQuestion then: how can I change the color by using CSS? Which class defines the color?
Thnx!
Comment #15
Marc Bijl commentedAllright, here's what I did.
- Opened the star.png from the widget I use (oxygene) in Photoshop
- Changed the value for Hue (via adjustments, hue/saturation)
- Saved and replaced the star.png at the server
Is this the right way to achieve the color change of stars?