[master] Location and GMap

Great! The location chooser works again!
There's a minor problem, though: upon setting the location, the map automatically zooms in. However, it does not center on the marker position, so that sometimes the marker disappears from the map. However, this does not affect the functionality.

Thanks!
Ben.

I dont know id youd like it reported here or in its own issue but GMAP is triggering on the user locations page:

    * warning: array_intersect() [function.array-intersect]: Argument #1 is not an array in /var/www/vhosts/myhost/httpdocs/sites/all/modules/gmap/gmap_location.module on line 86.
    * warning: array_intersect() [function.array-intersect]: Argument #1 is not an array in /var/www/vhosts/myhost/httpdocs/sites/all/modules/gmap/gmap_location.module on line 86.

Just to give an update on the problems I still experience with the latest version:

- the gmap block does not get shown (mentioned somewhere else as well)
- gmap views don't show any markers (the /map/node gmap however works fine)

Looks like those are the only two things keeping me from updating!
Thanks for working on this, and if you would like me to test specific things, let me know!

Cheers,
Ben.

I walked through the issue with saving locations, and understand the problem (both location and gmap are, on node creation, trying to do an insert - and hence the second one fails).

However I was not able to fix this because I don't really understand what the intended function is. Both gmap and location seem to have geocoding functionality. Why is this? Where is the right place for the geocoding functionality to live?
Once both the gmap and location developers have clarified/agreed on this then I think we can work on a solution. One thing I would suggest is for gmap to use a location save API (which we will need to create), rather than directly accessing the database.

In that case I would like to propose that we remove the gmap_location hook_nodeapi() and hook_user(). Location module already does the geocoding, as you say - and has a nice infrastructure to allow multiple geocoding providers.

This would leave gmap_location with the functionality of choosing markers for user roles and node types, the location block, and the global user/node maps.
These would be switched to use $object->locations[$index]['latitude'] (or location or lat as appropriate) instead of $object->gmap_location_latitude to find a node or users lat and long.

Does this sound reasonable? I don't think this would cause any loss in functionality (unless I am missing something) and would prevent the duplication errors currently occurring in gmap_location, as well as simplify the code!

I realized that the problem with the gmap views (see #6) is that I did not select the latitude & longitude fields. In the 4.7 version, this was no problem, and I would prefer if this was not required for the gmap view to work. But maybe this is rather a problem of the views module?

Ben.

I also agree with Ben. I would like to not set lat, long in views' fields. When you set lat, long in views' fields, there's no way to hide them on popup windows. I like the 4.7 version in which it doesn't require.

As a workaround, You can hide the lat and long co-ords with CSS
I'll post the simple CSS I use to do this if anyone is interested
[I don't have access to it on this machine]

Would be great if you could post the code!
Thanks!
Ben.

That would work for me - but I guess it should be well-documented, to avoid confusion...
For me it would be ok to use css to hide it - maybe that's more usable?

Ben.

The views thing seems pretty unrelated to this issue ;)

I would be really interested in feedback on my proposal in #9. Unless anyone can point out a reason for this code to exist it seems best to remove it (since it is causing PHP warnings).

Simple css as requested in #13

.gmap-map .latitude,.gmap-map .longitude {
  display:none;
  }  

Let us know how it goes.
Alan

@#17: Thanks, Alan, it works great! And sorry for getting off topic...

Ben.

I guess I had missed the lack of this feature before since we normally use CiviCRM (which works with location) for storing user locations.
I'll take a look!

IRT: http://drupal.org/node/118993

When re-editing any node where the location can be set with a Google-map (working with the location module), the lat and long values return to the default node values set in the GMAP settings. So a minor edit on the text leads to the location being re-set.

I was able to solve this on 4.7.x by adding:

$keep = 1;

Just before:

if ($keep) {
_location_save($node->locations[$index] ? $node->locations[$index] : array(), $node, 'node');
}

In location.module.

Issue was location would check to see if the location information was empty, and delete the record if it was, but it didn't check if it gmap had location information. This patch means location will never delete records, but will leave empty records, which seems fine in this case. (IMHO)

Not sure if this will help your 5.x plight. This should be fixed in a sane way, and applied to 5.x and backported to 4.7.x.

Robin

Thanks for all the work, folks. Looking forward to geocoding coming from somehwere. Right now, map selection works, but a lookup from the location fields is something to look forward to.

I've been looking around at a lot of issues. Is geocoding supposed to work, now? Somehow? Maybe yes, maybe no?

I'm also having Geocoding issues with Location and GMap in 5.x, it's a bit complex so I'm going to try and explain them as much as possible but you'll still probably need to read it all twice:

1- GMap & gmap_location has the geocoding functionality
2- The address field and nodeAPI function (among others, but I think these are the more important) are commented out in gmap_location.
3- Location doesn't have the proper field for doing the address->long/lat conversion for nodes
4- gmap_location depends on location, location depends on gmap for it's functions

I end up with the big requirement loop, but yet I still can't get a node with a address field that a user can use to geocode their address/postal code into a long/lat. I contemplated making location not require gmap, but since the geocoding functions and the views display type are there, it didn't make sense for my limited time. I also contemplated uncommented that address field, have both sets of address fields display, using css to hide locations, and have location handle the submitted data (what I had done 4.7), but a non-intensive walk though the codebase made this looks unlikely.

Some information on how to get this working, or if some work needs to be done a good clear reference on where to do it would be invaluable for me at this point.

Robin

warning: array_intersect() happens to me when I delete a user from my drupal site.

I just took the latest GMap snapshot (2007-Oct-10) and location setting is not working here. This is with the latest location.module (2007-Oct-08).

When one tries to enter location information on a node, the map appears but is not centered correctly (see http://drupal.org/node/144290#comment-322422).

When one clicks on the map to set location a marker appears and the maps zooms in. The marker is being placed in the wrong location though (not where the click was). From what I can tell it is always too far North. The distance out seems to be variable - the higher the zoom (ie, only 1Km top to bottom on the map) the closer things are. With zoom set so a whole country on display the marker can appear many more miles North.

This is odd, as when one enters lat/long manually the marker is placed in the correct location.

I must apologize for the last comment... it would see the problem (points recorded too far north) is only happening on one PC that has the Beta version of Firefox 3 (Mozilla/5.0 Gecko/2007091216 GranParadiso/3.0a8) installed.

Slightly odd that the browser would cause the issue, but confirmed last night that on different machine with FF2 things are fine.

quoting #26 "I end up with the big requirement loop, but yet I still can't get a node with a address field that a user can use to geocode their address/postal code into a long/lat."
That's exactly my issue: I simply want user profiles to have an address field and a map. I hope this will be possible some distant day (with recent advances of science, technology and stuff, you know ;)

Subscribing.
Very interesting!
greetings,
Martijn

Where can I find the most updated instructions for installing the GMap module? The ones downloaded with the module states it's outdated. Thanks for the help.

Subscribe

Sorry, Subscribe where?

Subscribing