This patch will allow user-submitted coordinates on user nodes.

Having this capability will mean gmap_location no longer has any reason to write to the location table directly, and I can finally remove that section of code. (Yay!)

--Brandon

CommentFileSizeAuthor
location-user-latlon.patch2.16 KBbdragon

Comments

owen barton’s picture

owen barton commented

This looks good to me!

spooky69’s picture

spooky69 commented

Has this been committed to the latest version? Using gmap, when a user edits their account the location information previously set is reset to zero and the location therefore lost. I am aware that this is a known issue, but cannot seem to find out if this has been fixed or not.

bdragon’s picture

bdragon commented

Nothing in location has changed for 2 months...

jarvis-1’s picture

jarvis-1 commented

bdragon, what piece of code is it that you want to remove from gmap? I'll happily apply this patch to my own installation of drupal, I just need to know what parts need to be edited out.

bdragon’s picture

bdragon commented
Priority: Normal » Critical

At the moment, I believe this patch can coexist with an unpatched gmap_location, as I fixed the resetting bug in gmap_location.

I am planning on removing the ability of gmap_location to set user locations completely in the very near future. It would be a good time to get this feature in!

I am tracking the GMap side of the issue at http://drupal.org/node/172841 now.

bdragon’s picture

bdragon commented

http://drupal.org/node/58795 marked duplicate.

catch’s picture

catch
he/him
Primary language English
commented

does this need to be re-rolled against location 2.x? http://drupal.org/node/169712

bdragon’s picture

bdragon commented
Version: 5.x-1.x-dev » 6.x-3.x-dev
Assigned: Unassigned » bdragon
Status: Needs review » Needs work

Since there are no barriers left to getting this rolled in, it's now one of my tasks for Location 3.

bdragon’s picture

bdragon commented

Bumping to remind myself.

bdragon’s picture

bdragon commented
Status: Needs work » Fixed

Locations now use the same code for both nodes and users.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.