[META] #125001: Allow user submitted coordinates on users / gmap_location rewrite

bdragon - September 4, 2007 - 02:20
Project:GMap Module
Version:5.x-1.x-dev
Component:Miscellaneous
Category:task
Priority:critical
Assigned:bdragon
Status:patch (code needs work)
Description

This is a meta issue for the gmap side of http://drupal.org/node/125001.

#1

bdragon - September 4, 2007 - 02:32

This copy of gmap_location.module is the last version with support for submitting user locations built in. (Remove the .txt to use.)

AttachmentSize
gmap_location.module_0.txt27.74 KB

#2

bdragon - September 8, 2007 - 00:04
Title:[META] #125001: Allow user submitted coordinates on users» [META] #125001: Allow user submitted coordinates on users / gmap_location rewrite

I was hacking away all day on gmap_location.

Removed features:
* Custom theming for acidfree removed, as it didn't work anyway.
* Adding user locations removed, use #125001 or convince me to roll it into another module.
* Buddylist friend lines removed, due to speed concerns in the current implementation. Reimplementing this as an addon would be nice.

Changed:
* Avoid user_load and node_load by using more complex queries. Decreases page generation time by, um, a lot.
* Force highest RID to take effect when determining user marker.
* Rewrote the admin interface.
* Rolled a bunch of variables together (update provided).
* Don't hide content types that do not have location capability, mark them as being so instead.
* LOADS of cleanup.

Added:
* AHAH callbacks for the info windows, drastically reducing page size and increasing speed.
* You can now specify a page footer as well as a page header.
* hook_node_type implemented, the marker settings will honor renames of node types, and will clean up after itself.
* Uninstall hook added (not quite finished)

Todo:
* Figure out how to fix the OG behavior for content types with the node type other than 'og'.
* Ensure I didn't screw up anything else.
* Look through the block section (I didn't get around to touching it yet)
* Finish the uninstall hook (variables from the block section aren't cleaned up yet)

AttachmentSize
gmap_location_rewrite.patch34.27 KB

#3

bdragon - September 19, 2007 - 00:04

http://drupal.org/node/140553 marked as duplicate.

#4

catch - October 2, 2007 - 10:14

I'd like to see this get in, anything much to be done with testing? If I get a chance later this week I'll try to apply it on a test site and at least see how much difference it makes to my node map which was crawling before.

#5

bdragon - October 4, 2007 - 20:31

OK, to make the transition easier, I decided to split out the users coordinates stuff so it lives in a temporary module. That means I can get the rewrite finished even without location's help.

#6

catch - November 7, 2007 - 11:52
Status:active» patch (code needs work)

bdragon: I'm very interested in

* Avoid user_load and node_load by using more complex queries. Decreases page generation time by, um, a lot.

Just applied this, very nice. My node map is showing forum topics instead of the actual geocoded nodes (of a different type) though. Needs a re-roll for teaser.js as well so setting to needs work.

#7

csc4 - December 4, 2007 - 17:02

Subscribing

Also - would it be possible for the release with this in to be a point release so that update status can monitor all the good work you're doing?

#8

Benjamin Melançon - December 24, 2007 - 11:36

subscribing

#9

bdragon - December 29, 2007 - 01:08

All of the speed related changes should now have been copied into CVS. The user map should now have the speed benefits, as of the next snapshot.

 
 

Drupal is a registered trademark of Dries Buytaert.