Pclzip module for Drupal 7

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. Please see the documentation about release naming conventions and creating a branch in git.

Please remove the LICENSE.txt file. Drupal will add the appropriate version automatically during packaging so your repository should not include it.

I noticed some very small code style issues. Please run the coder module on "minor" setting to help catch these. I noticed things like using multiple spaces to get all the => to line up inside arrays, indenting with tabs or more than 2 spaces.

In your query:

$result = db_query("SELECT field_name FROM {field_config} WHERE type IN (" . variable_get('pclzip_field_types', "'image','file'") . ")");

It would be better to use db_placeholders or completely change the user interface to use checkboxes of "known good values" that you can trust inside the query. This is a "sql injection" but since it requires "administer site configuration" to exploit it does not heed to be handled via the private security process.

You should probably also follow the abandoned project process to gain control of the other module so you can fix these issues and become maintainer of the main project.

Thanks for your work!

I didn't fully realize this was a 7.x module, sorry. Please see "Placeholder arrays" area on http://drupal.org/node/310072 for details of how to fix it.

Be sure to test the code after any fixes and question my advice - I'm not perfect, after all ;)

Getting there!

$result = db_query("SELECT field_name FROM {field_config} WHERE type IN (:files)",array(':files'  =>  variable_get('pclzip_field_types', "'image','file'")));

The argument is not an array.

I think:

$result = db_query("SELECT field_name FROM {field_config} WHERE type IN (:files)",array(':files'  =>  explode(',', variable_get('pclzip_field_types', "image, file")));

Note that I'm using explode and removed the ' from around the arguments in the variable. You will need to update the default elsewhere as well I think.

Great, be sure to set it back to needs review after fixing things listed here.

• The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org. It makes module updates easier if the library is not placed in the module folder.
• It's only necessary to declare files[] if they declare a class or interface.
• rename your module to pclzip and create an issue in the pclzip issue queue to offer maintainership.
• module file: @file doc block missing, see http://drupal.org/node/1354#files
• pclzip_d7_menu(): indentation errors, always use 2 spaces per level. Did you run coder with the "minor" setting?
• "// get the temp file": all comments should start capitalized and end with a "."
• "variable_get('pclzip_available_fields',$defaults)": there should be a space after ",".
• README.txt is missing. Please take a moment to make your README.txt follow the guidelines for in-project documentation.

@30equals, that sounds like you are on the path to take over the module but please follow http://drupal.org/node/251466

So it seems you don't need to create a new full project anymore. Please integrate your development with the existing pclzip module, either by posting patches or getting maintainership.

Please open a new issue if you have another new project that you want to promote to a full project.

No, the drupal.org webmasters can grant you maintainership on that particular project, if the old maintainer does not respond. And of course a maintainer herself can grant you access to the project.

30equals, I think you're following the right process. Based on your work here I granted you the git vetted user status. Please keep working toward creating the 7.x-1.x branch.

@30equals, sorry for the confusion but I think the documentation is outdated. You can be added as maintainer to a project without you having the "promote to full projects" permission. Will fix that.

hello
i am the maintainer of this project.
- i admit that i don't follow this project anymore for the moment because i don't need it actually.
- i am happy to see that someone is posting ideas about the upgrade of the module.
- i agree that someone can be co maintainer of the project.
- i can see that greggles and klausi helped to check the validity of the code.
- i think that the job is not to update only this core module and that the effort can be done on other pclzip modules too and i hope that someone will update them too.

i will look on the project page on how to grant someone to be a co maintainer.
edit : 30equald is now granted as co maintainer of all the pclzip modules.

all that said, i wanted to mention too (no obligation to read after this point) :

this module was made to be like a central module to be used with extensions :
pclzip_zipfolder
pclzip_zip_node_files
pclzip_zip_content_files
without any of theses module, we have nothing to do with it except developing own private projects.

30equals contacted me with the d.o contact form on the same day than writing this message (june 30).
i have answered on july 1st that i dont have time for the moment to watch the code and i will take a look during july (that i did not do).
30equals told me that i will be informed when one of the related modules will be ported and informed me about this actual thread (i forgot to "subscribe" to it so i did not receive new messages notifications).

then the discussion went here during october and, on the 1st of november, i receive an email with "the module is updated and reviewed".
then i went to see the code and i could see that the db placeholders are not well used (the same mistake i have made in the d6 version) so i tell it in my email on nov 4.
on today, 30equals reminded me the link to here and i could read all the disussion :)

all of this to tell you that i was answering to messages and taking care about the subject and saying that i am not answering is not the truth.

anyway, there is someone motivated to update the project, i can not refuse the opportunity but really hope that other modules will be updated too.

edit 2: i hope that i did not scare everybody with my answer and that everything will be fine :)

edit 3: i could see on today (12/03/18 that 30equals made a pclzip_zip_node_files d7 version. i was afraid that nobody would do the job and i can see now that i was wrong.
thank you and congratulations to 30equals for taking care about this module.