Closed (fixed)
Project:
Chatroom
Version:
4.7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
19 Feb 2007 at 16:16 UTC
Updated:
15 Mar 2007 at 02:18 UTC
Jump to comment: Most recent file
Chat Room provides a file for each chat (the cache file) that records the time when the last message was sent. This saves users from updating unnecessarily. At the same time, the only way for Chat Room to recognize a user as on line is for the user to update.
If no messages have been sent for a long time, the first user to send a new message will appear to be the only user on line. The other users will then update, making it appear that they just joined the chat.
In order to prevent false "user has left the chat" messages, I modified the code to not generate these messages within the first five seconds after an update. This works if the update is caused by a user joining the chat, but not if the update is caused by a user sending a message. I don't understand why it's not working.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | chatroom_8.patch | 1.54 KB | darren oh |
| #5 | chatroom_7.patch | 12.08 KB | darren oh |
| #1 | chatroom_6.patch | 8.25 KB | darren oh |
Comments
Comment #1
darren ohHere is the patch that isn't working.
Comment #2
darren ohComment #3
darren ohHere's an updated patch to work with the cleaned-up code in the development version. I still haven't succeeded in delaying the "user has left" message.
Comment #4
darren ohUntil Drupal is fixed, you will need to apply the patch from issue 121876 to use this one.
Comment #5
darren ohPatch was missing. I'm going to commit this because it makes the code easier to work with even though it doesn't solve the problem.
Comment #6
darren ohPatch committed in CVS commit 57780.
Comment #7
darren ohI've thought of a way to work around the problem. For each cache file (an empty file that exists to show the time of the last update) we store the old timestamp. If the current timestamp is less than five seconds old, we use the old timestamp to determine who's online. If the current timestamp is more than five seconds old, we use the new timestamp.
A rough draft of the idea is attached.
Comment #8
darren ohFixed in CVS commit 58658.
Comment #9
(not verified) commented