Thank you Kristof! for create new branch to support cck multigroup 6.3-dev. Here is my rough patch to make it works with Display Suites 6.x-2.x-dev branch and Node Display Contribute 6.x-3.x-dev branch.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vtsan’s picture

Here is the right patch file name

jstoller’s picture

subscribe

Anybody’s picture

Thank you very very much for the patch, I was just wondering that nothing worked anymore since the last update. Works great for my quite huge case.
I also anounced your patch here: http://julian.pustkuchen.com/drupal-cck3-multigroup-display-suite-ds-tab...

Anybody’s picture

Sorry but I still have a little problem after patching: The Field labels don't show up. Fieldgroups work, but CCK labels went away. Just the ":" shows up in front of the field value in full node view.

Any ideas on that or can anyone confirm?

jstoller’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
14.63 KB

I went through Vincent's patch and compared it to the current 6.x-1.x-dev version. It looks like there were a lot of unnecessary discrepancies, likely do to older workarounds and such. This patch should bring this version closer to that version, with the addition of multigroup specific changes. At the very least, I think it is a cleaner starting point. You might consider committing it for that reason alone. It mostly works! ;-)

This patch has fixed a problem I was having with fieldsets not rendering properly. However, I too am still having an issue with missing field labels. For some reason the $field['title'] variable is empty by the time it gets to the theme functions. I haven't been able to trace back where the problem lies though. Any suggestions would be appreciated.

jstoller’s picture

Title: Support Multigroup DS branch 6.x-2.x-dev and Nd_contrib 6.x-3.x-dev » DS Multigroup support
FileSize
14.55 KB

Here's a minor update to the patch, removing some code junk I just noticed.

The label issue seems to affect the 6.x-1.x-dev version as well. It looks like the latest devs are only setting that title variable for ds fields and ignoring cck fields. I'll keep looking into it.

@Anybody: can you test this patch and let me know if you see any other problems with it? If not, then we should try to get it committed soon, as a step in the right direction. It will make it easier for the maintainers to incorporate fixes which go into 6.x-1.x-dev.

Anybody’s picture

@jstoller: Thank you very much. I will try to test it today, currently I am very busy. I'll post my feedback here asap!

Anybody’s picture

@jstoller: Works great! Just the missing cck titles are really bad. I'm sorry that I haven't got enough time currently to check it out myself.
I hope that will be resolved soon.

jstoller’s picture

Status: Needs review » Reviewed & tested by the community

@Anybody:
Thanks for testing the patch. I'm marking this RTBC. I've filled a separate issue for the CCK label problem: #1214052: Label and complete cck theme flow missing on CCK fields.

@swentel:
If you're following this, can you please commit this patch. It may not be perfect, but it gets things (mostly) working again and gives us a cleaner baseline to develop from.

swentel’s picture

Status: Reviewed & tested by the community » Fixed

Committed this, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.