Node type restriction breaks the query if used on multiple elements

Try using 'two word' node types vs 'oneword' node types.... Actually... you are searching node.type using the node_type.name field... which is incorrect. It will work fine with one word node types. Pages, Stories, Articles etc... but when you use two word node types... the node_type.name field becomes "Bumper Sticker' for example... and the node_type.type field becomes "bumper_sticker" When you pull "Bumper Sticker" from node_type.name and you try to search it against node.type... it will fail... because the variable in node.type is "bumper_sticker" not "Bumper Sticker". I suspect the module doesnt really get tested using multiple word node types hence why the problem hasnt been detected before now. I already tested this theory... I changed the human readable name of my node_type.name to 'bumper_sticker' to match the machine readable node_type.type BAM... it worked. Problem there is I dont really want to use 'bumper_sticker in my select list... looks cheesy.

Query string that doesnt work:

SELECT DISTINCT node.nid, "nid" AS base_field, "node" AS base_table, node.title AS finder_element_3_node_title, node_type.name AS finder_element_4_node_type_name FROM node node INNER JOIN node_type node_type ON node_type.type = node.type WHERE ((node.type IN ('adhesive_decal_10x14','bumper_sticker','button','magnetic_sign') AND ((node.title LIKE '%obama%'))) AND (node.type IN ('Bumper Sticker','','','') AND ((node_type.name LIKE '%%')))) AND node.status = 1 GROUP BY node.nid LIMIT 0, 5

This (node.type IN ('Bumper Sticker','','','') is wrong. Clearly it IS trying to search 'Bumper Sticker' IN node.type which will fail.

If I change the node_type.name to 'bumper_sticker' and rerun the query again

SELECT DISTINCT node.nid, "nid" AS base_field, "node" AS base_table, node.title AS finder_element_3_node_title, node_type.name AS finder_element_4_node_type_name FROM node node INNER JOIN node_type node_type ON node_type.type = node.type WHERE ((node.type IN ('adhesive_decal_10x14','bumper_sticker','button','magnetic_sign') AND ((node.title LIKE '%obama%'))) AND (node.type IN ('bumper_sticker','','','') AND ((node_type.name LIKE '%%')))) AND node.status = 1 GROUP BY node.nid LIMIT 0, 5

Now it works... now it finds all Obama bumper stickers

Just to be clear... I am running two elements. One is a text box for the wording the other is a drop down list for the type.

Also... your screenshot shows the query being called at line 1143.... in my module (6.x-1.10) line 1143 is a blank line:

1143
1144 /**
1145 * Build finder code string recursively.
1146 */

Ok... I updated to the dev version.

Still experiencing the same problem

Its still looking in node.type for 'Bumper Sticker'

SELECT DISTINCT node.nid, "nid" AS base_field, "node" AS base_table, node.title AS finder_element_3_node_title, node_revisions.body AS finder_element_3_node_revisions_body, node_type.name AS finder_element_4_node_type_name FROM node node INNER JOIN node_revisions node_revisions ON node_revisions.vid = node.vid INNER JOIN node_type node_type ON node_type.type = node.type WHERE ((node.type IN ('adhesive_decal_10x14','bumper_sticker','button','magnetic_sign') AND ((node.title LIKE '%obama%' OR node_revisions.body LIKE '%obama%'))) AND (node.type IN ('Bumper Sticker','','','') AND ((node_type.name LIKE '%%')))) AND node.status = 1 GROUP BY node.nid LIMIT 0, 5

array(
  'finder_id' => '2',
  'base' => 'node',
  'title' => 'SignageMart Product Locator',
  'description' => '',
  'path' => 'search',
  'block' => '1',
  'settings' => array(
    'form_on_page' => 0,
    'form' => array(
      'prefix' => '',
      'prefix_format' => '1',
      'suffix' => '',
      'suffix_format' => '1',
      'button_text' => 'Search',
      'go_text' => 'Go',
    ),
    'advanced' => array(
      'no_results' => array(
        'no_results' => 'There are no results to display',
      ),
      'filter' => 0,
      'validate_empty' => 0,
      'submission' => 1,
      'ahah' => 0,
      'ahah_effect' => 'none',
      'ahah_remote' => 0,
      'element_combination' => '0',
      'pager' => '5',
      'goto' => '',
      'hide_args' => 1,
      'arg_sep' => ',',
      'empty_symbol' => '',
      'show_links' => 0,
      'show_admin_links' => 0,
      'cache_finder_find' => '0',
      'search' => '0',
      'search_tab' => 'node',
    ),
  ),
  'elements' => array(
    '0' => array(
      'finder_element_id' => '3',
      'finder_id' => '2',
      'element' => 'text',
      'title' => 'Search Products',
      'weight' => '0',
      'settings' => array(
        'form' => array(
          'description' => '',
          'prefix' => '',
          'prefix_format' => '1',
          'suffix' => '',
          'suffix_format' => '1',
          'default_value' => '',
          'required' => 0,
          'field_prefix' => '',
          'field_suffix' => '',
          'maxlength' => '',
          'minlength' => '',
          'size' => '40',
          'rows' => '0',
        ),
        'choices' => array(
          'field' => array(
            'node.title' => 'node.title',
            'node_revisions.body' => 'node_revisions.body',
          ),
          'node_types' => array(
            'adhesive_decal_10x14' => 'adhesive_decal_10x14',
            'bumper_sticker' => 'bumper_sticker',
            'button' => 'button',
            'magnetic_sign' => 'magnetic_sign',
          ),
          'published' => 1,
        ),
        'advanced' => array(
          'delimit' => '',
          'field_combination' => '0',
          'value_combination' => '0',
          'nesting_order' => '0',
          'match' => 'c',
        ),
      ),
      'element_handler' => array(
        '#title' => 'Text',
        '#module' => 'finder_text',
      ),
      '#_finder_object' => '1',
    ),
    '1' => array(
      'finder_element_id' => '4',
      'finder_id' => '2',
      'element' => 'select',
      'title' => 'Products',
      'weight' => '1',
      'settings' => array(
        'form' => array(
          'description' => '',
          'prefix' => '',
          'prefix_format' => '1',
          'suffix' => '',
          'suffix_format' => '1',
          'default_value' => '',
          'required' => 0,
          'size' => '',
          'multiple' => 0,
          'empty' => 'prepend',
          'empty_text' => 'All Products',
        ),
        'choices' => array(
          'field' => array(
            'node_type.name' => 'node_type.name',
          ),
          'sort' => 0,
          'node_types' => array(
            'adhesive_decal_10x14' => 'adhesive_decal_10x14',
            'bumper_sticker' => 'bumper_sticker',
            'button' => 'button',
            'magnetic_sign' => 'magnetic_sign',
          ),
          'published' => 1,
          'per_result' => 0,
          'rewrite' => array(
            'php' => '',
          ),
        ),
        'advanced' => array(
          'delimit' => '',
          'field_combination' => '0',
          'value_combination' => '0',
          'nesting_order' => '0',
          'match' => 'c',
        ),
      ),
      'element_handler' => array(
        '#title' => 'Select list',
        '#module' => 'finder_optionwidgets',
      ),
      '#_finder_object' => '1',
    ),
  ),
  'elements_index' => array(
    '3' => 0,
    '4' => 1,
  ),
  'base_handler' => array(
    '#title' => 'Node finder',
    '#module' => 'finder_node',
  ),
  'admin_links' => array(
    'search' => 'View \"Path\"',
    'admin/build/finder/2/edit' => 'Edit',
  ),
  'links' => array(),
  '#_finder_object' => '1',
)

Thank you for identifying the issue. At the time of this posting I notice the dev 7 version had been updated but not the dev 6 version (still showing a July 3 release).

If I had a nickel for every time I saved to the wrong file... I'd be retired to some secluded beach with half naked women serving me frozen drinks with little umbrellas all day long. Btw... thank you for all your hard work providing a superior search module. The functionality of this code is awesome! Heads above the rest.

I do have one more question. Is there a way on this node.type search to make an all of the selected types? For example I dont want to include all node types, I want to only select individual product types... but also give the user an ALL selection to check ALL product types for the search terms?

Regards,

I hate to be a PITA.... but I downloaded the newer code... still having the same problem and I dont see any changes in the finder_node_finder_find() between the old and new code. So Im wondering if you accidentally posted the wrong version?