In drupal 7.x hook_permission() takes title and description text besides machine name see http://drupal.org/update/modules/6/7#descriptions_permissions

Quiz module defines following permission string, I would like to get unambiguous title and description text suggestion from native speakers,

administer quiz configuration
access quiz
create quiz
edit own quiz
edit any quiz
delete any quiz
delete own quiz
view any quiz results
view own quiz results
view results for own quiz
delete any quiz results
delete results for own quiz
score any quiz
score own quiz
view quiz question outside of a quiz
view any quiz question correct response
edit question titles
assign any action to quiz events
manual quiz revisioning
Edit global presets
use regex for short answer

I have had bitter experience when I tried adding UI texts in my own English :-)

CommentFileSizeAuthor
#8 permissions-1211068.patch5.95 KBvegardjo

Comments

vegardjo’s picture

vegardjo commented
Assigned: Unassigned » vegardjo

Not a native speaker myself, but I'll give this a try next week

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

Thanks vegardjo. I really appreciate it.

vegardjo’s picture

vegardjo commented
Status: Active » Needs review

Here's a stab at this. Structure is:

machine name
title
description

I haven't added descriptions where I don't find that they are needed.

I also need some feedback on this one:

"view any quiz question correct response
View any quiz question correct response
Allow the user to see the correct answer, when viewed outside a quiz."

..I don't really understand what this does, but I found that description in a patch somewhere. Can someone confirm that this is a correct description of what the permission does?

I plan to leave this for review over the weekend, and will make a patch for it early next week with any adjustments.

---->

administer quiz configuration
Administer Quiz configuration

access quiz
Access Quiz
Can access (take) all quizzes.

create quiz
Create quiz

edit own quiz
Edit own quiz

edit any quiz
Edit any quiz

delete any quiz
Delete any quiz

delete own quiz
Delete own quiz

view any quiz results
View any quiz results
Can view results for all quizzes and users.

view own quiz results
View own quiz results
Quiz takers can view their own results, also when quiz is not passed.

view results for own quiz
View results for own quiz
Quiz makers can view results for their own quizzes.

delete any quiz results
Delete any quiz results

delete results for own quiz
Delete results for own quiz

score any quiz
Score any quiz

score own quiz
Score own quiz

view quiz question outside of a quiz
View quiz question outside of a quiz
Question nodes are only visible when in taking a quiz unless this permission is given.

view any quiz question correct response
View any quiz question correct response
Allow the user to see the correct answer, when viewed outside a quiz.

edit question titles
Edit question titles
Questions automatically get a title based on the question text. This allows titles to be set manually.

assign any action to quiz events
Assign any action to quiz events
Enables Drupal’s actions system for Quiz triggers.

manual quiz revisioning
Manual quiz revisioning
Quizzes are revisioned automatically each time they are changed. This allows you to do revisions manually.

edit global presets
Edit global presets
Can edit global configuration valid for all new quizzes.

use regex for short answer
Use regular expressions to score short answers

nirvanajyothi’s picture

nirvanajyothi commented

View any quiz result (after 'any', singular form is used for countable nouns i guess)
Allows access to all quiz results.

View own quiz results
Quiz taker is restricted to viewing his/her own results.
Or,
Quiz takers are restricted to viewing their own results.
Quiz takers can view their own results and not results of other users.

View results of owned quizzes
Quizmasters can view results of quizzes they created.
Or,
Quizmasters can view results of quizzes they manage.

Delete any quiz result (singular, again)

Delete results for owned quizzes

View questions outside quizzes
Quiz takers (or users) can access individual questions outside quizzes if this permission is given.
Or,
Questions can only be accessed via quizzes unless this permission is given.
Or,
Questions can be accessed via quizzes and not as individual nodes unless this permission is given.

View answers outside quizzes
Quiz takers can see the right answers, when questions are viewed outside a quiz.
(Depends on 'View questions outside quizzes' permission)

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

That looks a bit hard for me to read. I just created a wiki page in quiz group http://groups.drupal.org/node/162254. Let's make the changes there.

Good to see a doctor contributing to quiz :-)

nirvanajyothi’s picture

nirvanajyothi commented

@sivaji: Pleasure. :)

vegardjo’s picture

vegardjo commented

Excellent, I'll continue editing in the wiki. I'll try to make atomic changes so it's easy to read the diffs!

I originally though of changing "results" to "result" as it sounds better, and did change it in the wiki now. However, I'm getting second thoughts. Both forms (plural or singular) are allowed after "any", and if we change it in the title we should change it in the machine name too, but I don't know if changing the macine names is something that's in sivaji's scope now?

Also I won't change "own quiz" to "owned quiz", as "own" is used throughout Drupal (see permissions for node module for instance), and Quiz should follow those conventions. I'll have a look at the other changes later, thanks @nirvanajyothi :)

vegardjo’s picture

vegardjo commented
StatusFileSize
new permissions-1211068.patch5.95 KB

Here's a patch, applies fine here!

I agree with @nirvanajyothi on the "any result" / "any results" issue, but since both forms are allowed I chose not to change it now. If we change it I think it should be changed in both the machine name and title at the same time, and changing the machine name would create a much larger patch..

Also, didn't find these permissions in the .module file:

edit global presets
use regex for short answer

..have they been removed, or is it a bug?

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Component: Code - Quiz module » Code - Import/Export

@vegardjo and @nirvanajyothi thanks for your patch. I felt the Administer quiz configuration description was incorrect otherwise it is fine. Don't worry I have fixed it.

--- quiz.module
+++ quiz.module
@@ -81,93 +81,84 @@ function quiz_permission() {
   return array(
     // Configure quiz:
     'administer quiz configuration' => array(
-      'title' => t('administer quiz configuration'),
-      'description' => t('TODO Add a description for \'administer quiz configuration\''),
+      'title' => t('Administer quiz configuration'),
+      'description' => t('Allow the user to see the correct answer, when viewed outside a quiz'),
sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Component: Code - Import/Export » Code - Quiz core
Status: Needs review » Fixed
nirvanajyothi’s picture

nirvanajyothi commented

@Sivaji: That's great. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 0bc8845 on 7.x-4.x, 7.x-5.x authored by vegardjo, committed by sivaji: 
    #1211068 Provide title and description for permission strings.

  • Commit 0bc8845 on 7.x-4.x, 7.x-5.x, quiz-pages authored by vegardjo, committed by sivaji: 
    #1211068 Provide title and description for permission strings.

  • Commit 0bc8845 on 7.x-4.x, 7.x-5.x, quiz-pages, 2269219 authored by vegardjo, committed by sivaji: 
    #1211068 Provide title and description for permission strings.

  • Commit 0bc8845 on 7.x-4.x, 7.x-5.x, 2269219 authored by vegardjo, committed by sivaji: 
    #1211068 Provide title and description for permission strings.