Two nested contextual links regions are active, when the outer region is hovered.

subscr

+++ b/modules/contextual/contextual.js
@@ -25,6 +25,10 @@ Drupal.behaviors.contextualLinks = {
+      $region.hover(
+        function() { $trigger.addClass('contextual-links-trigger-active'); },
+        function() { $trigger.removeClass('contextual-links-trigger-active'); }
+      );

I'm not really familiar with this pattern of using multiple anonymous functions. Just curious: what is the difference compared to this?

$region.hover(function() {
    $trigger.addClass('contextual-links-trigger-active');
    $trigger.removeClass('contextual-links-trigger-active');
});

Thanks, I understand. In fact, it's right there in the jQuery documentation...

Sorry for inadvertently changing the status.

Patch works as advertised. I'm not marking it RTBC yet because I only tested with Firefox 4 on a linux machine.

Trivial D8 reroll.

I can also confirm that the patch solves the issue on Firefox and Chromium.

Tagging.

sounds fine, but needs further testing I assume

If this is further tested and completed, will a bug fix be applied to a future version of d7? Not sure how these things work.

Yes, I believe this is backportable.

D7 Patch attached, which means I'm switching version to 7.x-dev. Should I be doing this another way?

I tested #13 on d7 dev and it fixed the issue for me.

illmasterc, drupaljoe: thanks for the patch and for testing it.

I'm setting this issue back to 8.x & 'needs review' because the core development work flow requires a commit to D8 before this can be backported to D7. I see that both patches are nearly identical, so this shouldn't be a problem.

I think we need someone to test the patch from #8 with the 8.x branch on IE8 and higher (and perhaps some other major browsers) so we can get the D8 patch committed asap.

Tagging for manual testing.

D8 patch from #8 no longer applies. This one should.

Contextual js is easy enough to port from patch in #8, but the old css has changed significantly. I believe this patch should do the trick, but looking into it further.

What scenario are folks using to test the nested contextual regions in D8? Basically, what's the easiest way to test this in D8?

Hmm, hook_node_view and add a node_view() call to its $node->content?
Needs to be 2 separates node I think.

Looks like this'll do it. On D8 with attached patch applied.

Tested with custom module in it's entirety below:

<?php

/**
 * Implements hook_test().
 */
function test_node_view($node,$two = 2, $three = 3, $four = 4) {
  if($node->nid != 2){
    $node->content['node2'] = node_view(node_load(2));
  }
}

Then just create two nodes, the second node will be embedded in the body of the first (and so would any other node that's not nid == 2). Visiting the default homepage should give the needed view.

Looking good. Can we get this into the D7 update coming next week?

Somewhat unimportant, but the above code snippet should read:

Implements hook_node_view() not
Implements hook_test().

Looks fine to me. Committed/pushed to 8.x, moving to 7.x for backport. Tagging as novice for the backport since this should be a straight re-roll.

Reuploading #13.

I can confirm #23 fixed the bug for me in D7.

#23 also fixed it for me.

Can you please verify what browsers you're testing in? We can't get this into D7 unless someone confirms in IE 6/7.

Works on IE7 (using IETester). Could not test IE6 because some script was dying on the page (not contextual.js though, it died even before applying the patch).

Tested in IE 7/8/9 - works perfectly.
IE6 failed for me, but this may be related to my setup.

Someone else, please confirm IE6 and lets move it into core ASAP. Very useful patch.

This issue should probably be re-rolled against D7 dev again, patch no longer applies cleanly.

I can verify that the patch in #30 applies cleanly and fixes the nesting issue in:

The latest Chrome for both Mac and PC, no issues.
The latest FireFox for both Mac and PC, no issues.

Per @webchick in #26:
IE 6 via IETester. Had JS issues too, but was able to get it to work by switching and testing both Garland and Bartick, even though they both still have stylistic issues with the themes themselves (not sure why IE6 is still being considered, but whatever), no issues.
IE 7/8/9 via IETester, no issues.
IE 10 on Win8, no issues.

Can we please get this committed finally?

Would like to see this get added to the queue for 7.23.

Nice improvement, and thanks for all the testing too.

Committed to 7.x! http://drupalcode.org/project/drupal.git/commit/c2a5709