"multiple-value" & "required" breaks input/save and produces error: "At least one title or URL must be entered."

Patch in #1038444: Extra required indicator shoudl fix that.

patch in #1038444: Extra required indicator is obsolete and error still reproducible

REMOVED -> D7 stable release blocker

Since the in #2 mentioned but sadly never committed patch of davereid from January didn't fit on the newer code automaticly no more, I had to manually apply it and create a retrieved version of it.

Here we go, let me know ... http://drupal.org/node/1038444#comment-5037138

we got to catch up. I reviewed by myself on 3 test installs. seems to work. committed to latest dev and marked for beta1

Hello, Just installed and tested the beta1 release. I encounter 2 similar problems. Please let me know if you prefer a new issue.

1- at the creation of a content type, I marked my link field as required. When creating the content type, I entered a value for the link title and the URL. Upon saving, I get an error that at least on needs to be eneterd. To solve this, I no longer marked the field as required, and now it works.

2- As I wanted to make a screenshot to document the issue, I flagged required again. Upon saving the content type, I got the error that error "At least one title or URL must be entered." again.

regards

Geert

geert, please use latest dev and report back (all info about why above)

but thx 4 your report!

Tried the dev version. Same behaviour.

I can also confirm the same issue as geert. When trying to save a required URL (with optional title), I receive the "At least one title or URL must be entered." even if the URL is in the form field.

What worked for me was to change:

..
  if ($instance['settings']['url'] == 'optional' && $instance['settings']['title'] == 'optional' && $instance['required'] && !$optional_field_found) {
..

To this (notice the ===):

..
  if ($instance['settings']['url'] === 'optional' && $instance['settings']['title'] == 'optional' && $instance['required'] && !$optional_field_found) {
..

There might be other cases that should be changed to === as well...

thx noahb! often it is because of the small things in such cases.

thank you for pointing it out!

noahb++

Here's a patch from #11.

thanks orakili and noahb! committed to latest dev. seems to work (here).