Undefined index caused by missing "remove" -checkbox in new permission

On submit I get this error. I traced it to missing remove-checkbox and made up a little patch.

Notice: Undefined index: remove in config_perms_admin_form_submit() (line 177 of /path/to/drupal/sites/all/modules/config_perms/config_perms.admin.inc).

My patch removes the permission field which is there by default and all new empty permission field gets the remove checkbox. To me this makes more sense than having always one empty permission there.

Comment	File	Size	Author
#1	0001-Fixed-undefined-index-notice-issue-number-1217478.patch	1.15 KB	jviitamaki

Comments

Comment #1

jviitamaki commented 13 July 2011 at 11:16

Status	File	Size
new	0001-Fixed-undefined-index-notice-issue-number-1217478.patch	1.15 KB

Here's the patch.

Log in or register to post comments

Comment #2

jviitamaki commented 13 July 2011 at 11:23

Status:

Active

» Needs review

Log in or register to post comments

Comment #3

Docc commented 13 July 2011 at 17:16

Status:

Needs review

» Closed (fixed)

Indeed. Committed thanx.

http://drupalcode.org/project/config_perms.git/commit/54cc199

Log in or register to post comments

joshuautley’s picture

Comment #4

joshuautley commented 17 April 2013 at 22:29

You're totally my hero right now. Thanks for the patch.

Log in or register to post comments