this puts advuser almost full working in drupal 5 but mailing user e removing them its not working yet.
I need mail for all users working ASAP.

Also tested this modulo with "Coder" and made the changes needed for "Drupal Coding Standards".

This also include changes from:
http://drupal.org/node/118684
http://drupal.org/node/118733

Please apply this.
I need some help completing to put mail for all working.

sorry for my bad english.

CommentFileSizeAuthor
#1 advuser.tar_.bz2_.txt7.74 KBxpete
advuser5.patch30.07 KBxpete

Comments

xpete’s picture

xpete commented
Title: drupal 5 patch » full package
StatusFileSize
new advuser.tar_.bz2_.txt7.74 KB

here goes the complete package.

Anonymous’s picture

Anonymous (not verified) commented
Status: Reviewed & tested by the community » Needs review

I don't see any review yet. We can't commit without review.

You're patch crosses some of the patches I have submitted. I will review your patch further and add the differences ASAP (which is hopefully this weekend).

M.Att’s picture

M.Att commented
Category: task » bug
Priority: Normal » Minor

There is a minor bug (if you will) in the advuser.info file - there is no dependency defined for the profile.module. Optionally is the second addition can be the package parameter so future additional usermodules can live in their own home :)

;$Id: advuser.info,v 1.1.2.1 2007/02/12 23:42:35 inactivist Exp $
name = "Advanced User Management"
version = "$Name:  $"
description = "Advanced user management module. Filter users and mass actions based on their filters."
package = Advanced User management
dependencies = profile
Anonymous’s picture

Anonymous (not verified) commented

No, the package value should not be set. It has a special purpose that this package doesn't meet the criteria for. To see the criteria look here http://drupal.org/node/64279 and here http://drupal.org/node/101009 and be sure to check the comments.

IMO, package is miss named but it was past freeze when I discovered it and now we will live with it.

mcurry’s picture

mcurry commented

Does this module break without profile.module enabled, or does it degrade gracefully? (sorry, I didn't write the code, and I've not yet used the profile-specific features.)

If it degrades gracefully without profile.module present and enabled, then I'd say that profile.module is not a dependency.

Comments?

Anonymous’s picture

Anonymous (not verified) commented

Good question. I don't have the answer as yet either. If this package doesn't need profile to operate then adding the dependency isn't the correct thing to do. There has been talk of adding a suggest variable which would then be displayed in the module list. I don't know that work has been created to go with the talk.

Anonymous’s picture

Anonymous (not verified) commented
Priority: Minor » Normal
Status: Needs review » Needs work

I've been playing with this for a few hours now. Xpete's patch isn't quite correct and with the new user administration interface the module needs some heavy overhauling. Xpete your patch also makes some code style changes. I would like you to move those changes to a separate patch.

The module has capabilities for deleting users as well. I don't think that functionality is needed with the newer user administration but I'll check it out. Most people are waiting on email from what I can tell; I know that is the functionality I'm longing for. What are peoples thoughts on the delete portion of this module?

xpete’s picture

xpete commented

I've used it with the new user administration and didn't find any problem with that.
I didn't changed the delete portion of this module because i don't need that but it could be useful
because it uses the profile fields as filters and the normal user edition don't.
The changes i've done in code style is to comply with "Drupal Coding Standards".
What i need is the mail thing working, I've done some work in that but can't put it fully working.

somebodysysop’s picture

somebodysysop commented

Just a thought. This package is designed to filter based upon profile fields. Would it be possible to filter based upon node profile (http://drupal.org/project/nodeprofile) fields?

Anonymous’s picture

Anonymous (not verified) commented

@SomebodySysop: That is a "feature request" that belongs in a new issue. This issue is trying to get a working 5.x module.

Has anyone else tried? We really need testers and commenters for this package. I've identified the coding formatting changes belong in a different patch. But how does everyone else feel about the patch? Given the lack of interest in this node, how can we raise awareness?

Inactivist, can we create a 5.x dev version with this patch? Maybe we'll get more interest.

mcurry’s picture

mcurry commented

I've committed the patch - I've not tested it much (I don't have any production drupal 5 sites)

http://drupal.org/cvs?commit=63581

I've created a drupal-5.x-dev release. As I said, not tested. Please try it out...

mcurry’s picture

mcurry commented

Earnie, this is my formal invitation to bring you in as a co-maintainer (grant you CVS access to this project) so you can continue helping with the 5.0 work in a more efficient manner.

Anonymous’s picture

Anonymous (not verified) commented

Ok, CVS access granted.

Anonymous’s picture

Anonymous (not verified) commented

@xpete: You patch doesn't contain ``callback arguments'' for ``advuser_multiple_email_confirm_page''. Please follow up with http://drupal.org/node/135213.

xpete’s picture

xpete commented

i've been away, now i'm using mass_contact.
I will update Advuser to see what as changed.

xpete’s picture

xpete commented

i've been away, now i'm using mass_contact.
I will update Advuser to see what as changed.

Anonymous’s picture

Anonymous (not verified) commented
Version: master » 5.x-1.x-dev
Status: Needs work » Fixed

@xpete: I have a patch that for the issue I spoke of. See http://drupal.org/node/135213 for more information. I'm marking this fixed so that we can close what has been uploaded to CVS.

xpete’s picture

xpete commented
Status: Fixed » Closed (fixed)