Problem with commerce_pdm_display_node_products_form and languages

1/ the notice I can't reproduce and I have the same set-up
Strange I don't see this notice.
I must say that part is indeed something strange with that language check there. I'll investigate it.

- Edit - I don't see notices, but I do see my products twice , doubling the list. Guess issues are related, but don't see how yet.

2/ the form I will move to another file
This is already pushed.

Notice: Undefined index: de in commerce_pdm_display_node_products_form() (Zeile 107 von /mnt/webc/42/58/51167658/htdocs/d/sites/all/modules/commerce_product_display_manager/commerce_pdm.module).
Warning: Invalid argument supplied for foreach() in commerce_pdm_display_node_products_form() (Zeile 107 von /mnt/webc/42/58/51167658/htdocs/d/sites/all/modules/commerce_product_display_manager/commerce_pdm.module).

Occuring on alpha3 and dev version...

We'll look into this asap. I have some other contribs that need to be released first and then my attention will go to the commerce project again.

Found the problem:

1. product reference field does not utilize correct language
2. need to check for correct language for current field not node prior iterating

Example:
- reference: $node->product_reference[und][product_id]
- language: $node->language = en

Might this issue be 'References' or 'i18n' module related.

Steps to reproduce:

- enable content translation
- enable i18n module
- create new content type and assign product reference field
- create a new product and assign referenced item to it
- use devel to see what's inside node

Quick fix: commerce_pdm.module (108 line)

    $ref_language = array_keys($node->{$reference_field_name});
    if ($ref_language[0] == $node_language) {
      foreach($node->{$reference_field_name}[$node_language] as $product_field_value) {
        $conditions->condition('cp.product_id', $product_field_value['product_id']);
      }
    } else {
      foreach($node->{$reference_field_name}['und'] as $product_field_value) {
        $conditions->condition('cp.product_id', $product_field_value['product_id']);
      }
    }

And yeas.. at line 320 (or so) you need another same fix, plus, there is a typo in variable name $node_language.

subscribing. same error here. only when i view the product list at a node

Bump.

I have the same issue, but the quick patch works nicely.
Any idea on a timing for a permanent fix ?
Thanks for the nice work so far !

Stef

Same issue here. Could you provide a patch for this?

I attached my fix for this issue.
As I see, we should never use this type of array access: $node->{$reference_field_name}['und'], because of what if I have other language than 'und' (which actually should be LANGUAGE_NONE constant).

My fix uses field_get_items() to solve this problem.

Sorry, I forgot set the status…

It still doesn't work for me. May be is my fault, but actually I don't think so.
I have a content type that is Magazine, that will be the Product Display Type.
When I create one, from scratch its language is specific (it, in my case).

When I try to attach a Product with the Product Display Manager UI to such a yet existing magazine, it doesn't work as it seems to expect und language content ... so no product is referenced to that display.
The Product Display Manager works well when I attach the product to a new Magazine (new node created on the fly). But in this case the new magazine is created with an 'und' language parameter, bypassing the locale settings of my site.

I think it is really a matter of language management, that #9 patch didn't fix for me ...

Patch #9 fixed it for me.

Confirmed: patch #9 works fine

Works.

Another vote for #9.

#9 works.

#9 It works, thank you.

yes, #9 works for me too.
I had just a problem with the Display Manager, that seems won't work properly (just gives any result …) when I have more than one product type defined and referenced to some of my content types (product display).
I just opened another issue about this, here: Display Manager doesn't work with more then one Product Types

#9 does the job.

#9 works for me as well, would be great to get this commited... Thanks!

#9 solved problems for me!
Patch tested and working fine.

Hi, there is a module named Commerce Auto Product Display which does similar thing like this module. You might want to use it because this module is no longer maintained.

Patch in #9 fixes this issue. Committed this to 7.x-1.x-dev. Thanks for contributing!