We need to adhere to Drupal coding standards. Current output of Coder module:

  • Line 18: use a space between the closing parenthesis and the open bracket
  • Line 20: use a space between the closing parenthesis and the open bracket
  • Line 61: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 101: use a space between the closing parenthesis and the open bracket
  • Line 105: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 106: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 107: use a space between the closing parenthesis and the open bracket
  • Line 119: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 120: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 124: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 126: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 133: use a space between the closing parenthesis and the open bracket
  • Line 135: global variables should start with a single underscore followed by the module and another underscore
  • Line 139: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 140: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 143: use a space between the closing parenthesis and the open bracket
  • Line 148: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 162: do not use mixed case (camelCase), use lower case and _
  • Line 164: Use an indent of 2 spaces, with no tabs
  • Line 165: Use an indent of 2 spaces, with no tabs
  • Line 166: Use an indent of 2 spaces, with no tabs
  • Line 170: do not use mixed case (camelCase), use lower case and _
  • Line 174: do not use mixed case (camelCase), use lower case and _
  • Line 180: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 181: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 208: use a space between the closing parenthesis and the open bracket
  • Line 212: use a space between the closing parenthesis and the open bracket
  • Line 236: use a space between the closing parenthesis and the open bracket
  • Line 237: use a space between the closing parenthesis and the open bracket
  • Line 238: _POST[op] deprecated in favor of $form_values[op]
  • Line 239: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 253: use a space between the closing parenthesis and the open bracket
  • Line 261: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 267: use a space between the closing parenthesis and the open bracket
  • Line 270: else statements should begin on a new line
  • Line 322: use a space between the closing parenthesis and the open bracket
  • Line 325: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 393: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 463: use a space between the closing parenthesis and the open bracket
  • Line 471: use a space between the closing parenthesis and the open bracket
  • Line 476: use a space between the closing parenthesis and the open bracket
  • Line 477: use a space between the closing parenthesis and the open bracket
  • Line 495: use a space between the closing parenthesis and the open bracket
  • Line 496: use a space between the closing parenthesis and the open bracket
  • Line 525: use a space between the closing parenthesis and the open bracket
  • Line 549: use a space between the closing parenthesis and the open bracket
  • Line 552: use a space between the closing parenthesis and the open bracket
  • Line 564: use a space between the closing parenthesis and the open bracket
  • Line 574: use a space between the closing parenthesis and the open bracket
  • Line 576: use a space between the closing parenthesis and the open bracket
  • Line 582: use a space between the closing parenthesis and the open bracket
  • Line 583: use a space between the closing parenthesis and the open bracket
  • Line 585: use a space between the closing parenthesis and the open bracket
  • Line 586: use a space between the closing parenthesis and the open bracket
  • Line 587: use a space between the closing parenthesis and the open bracket
  • Line 605: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 610: use a space between the closing parenthesis and the open bracket
  • Line 616: use a space between the closing parenthesis and the open bracket
  • Line 617: use a space between the closing parenthesis and the open bracket
  • Line 637: use a space between the closing parenthesis and the open bracket
  • Line 647: use a space between the closing parenthesis and the open bracket
  • Line 649: use a space between the closing parenthesis and the open bracket
  • Line 651: use a space between the closing parenthesis and the open bracket
  • Line 654: use a space between the closing parenthesis and the open bracket
  • Line 658: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 660: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 661: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 662: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 669: use a space between the closing parenthesis and the open bracket
  • Line 670: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 673: use a space between the closing parenthesis and the open bracket
  • Line 679: use a space between the closing parenthesis and the open bracket
  • Line 687: use a space between the closing parenthesis and the open bracket
  • Line 714: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 721: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 729: use a space between the closing parenthesis and the open bracket
  • Line 730: use a space between the closing parenthesis and the open bracket
  • Line 738: use a space between the closing parenthesis and the open bracket
  • Line 739: Use an indent of 2 spaces, with no tabs
  • Line 740: Use an indent of 2 spaces, with no tabs
  • Line 741: Use an indent of 2 spaces, with no tabs
  • Line 742: Use an indent of 2 spaces, with no tabs
  • Line 743: Use an indent of 2 spaces, with no tabs
  • Line 744: Use an indent of 2 spaces, with no tabs
  • Line 745: Use an indent of 2 spaces, with no tabs
  • Line 746: Use an indent of 2 spaces, with no tabs
  • Line 749: do not use mixed case (camelCase), use lower case and _
  • Line 750: Use an indent of 2 spaces, with no tabs
  • Line 751: Use an indent of 2 spaces, with no tabs
  • Line 754: do not use mixed case (camelCase), use lower case and _
  • Line 755: Use an indent of 2 spaces, with no tabs
  • Line 758: do not use mixed case (camelCase), use lower case and _
  • Line 759: Use an indent of 2 spaces, with no tabs
  • Line 760: Use an indent of 2 spaces, with no tabs
  • Line 761: Use an indent of 2 spaces, with no tabs
  • Line 762: Use an indent of 2 spaces, with no tabs
  • Line 763: Use an indent of 2 spaces, with no tabs
  • Line 764: Use an indent of 2 spaces, with no tabs
  • Line 765: Use an indent of 2 spaces, with no tabs
  • Line 769: do not use mixed case (camelCase), use lower case and _
  • Line 777: use a space between the closing parenthesis and the open bracket
  • Line 782: do not use mixed case (camelCase), use lower case and _
  • Line 789: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 799: Use an indent of 2 spaces, with no tabs
  • Line 800: Use an indent of 2 spaces, with no tabs
  • Line 801: Use an indent of 2 spaces, with no tabs
  • Line 812: use a space between the closing parenthesis and the open bracket
  • Line 813: string concatenation should be formatted with a space separating the operators (dot .) and terms ('string')
  • Line 814: use a space between the closing parenthesis and the open bracket
  • Line 827: use a space between the closing parenthesis and the open bracket
  • Line 828: missing space after comma
CommentFileSizeAuthor
#1 sifr.module.code-cleanup.patch4.74 KBsun

Comments

sun’s picture

Status: Active » Needs review
StatusFileSize
new4.74 KB

Attached patch fixes above coding style issues. It already contains http://drupal.org/node/109508 .

sun’s picture

Status: Needs review » Fixed

Committed to HEAD and 5.x.

Anonymous’s picture

Status: Fixed » Closed (fixed)