option to use <a href="#"> for "nolink" items to not break other modules

I've worked around this issue for the time being by adding the following javascript to my theme template. It's a hack at best but gets me past my last remaining issue preventing me from migrating a site to D7 until a real fix is released.

Here's the work around.
In your html.tpl.php for your theme find the line that says

<?php print $scripts; ?>

And add the following just after it.

    <script type="text/javascript">
        (function ($) {
                $(document).ready(function() {
                        // replace nolinks
                        $("[href='/%3Cnolink%3E']").each(function(index) {
                                $(this).replaceWith("<span class='nolink'>" + $(this).text() + "</span>");
                        });
                        // replace separators
                        $("[href='/%3Cseparator%3E']").each(function(index) {
                                $(this).replaceWith("<span class='separator'><hr></span>");
                        });
                });
        })(jQuery);
    </script>

Then you need to flush your sites caches for the change to take effect. This only works for the nolink menu items. With a few tweaks it shouldn't be difficult to extend this to work for separators.

EDIT: I modified the script to support separators. Note that this will only work if javascript is enabled by the client. It replaces nolink menu items with span tags and the separators with hr tags.

Login or register to post comments

#12

Posted by Yaazkal on October 21, 2011 at 3:46am

Hi, the code on #11 should be:

<script type="text/javascript">
        (function ($) {
                $(document).ready(function() {
                        // replace nolinks
                        $("a[href$='/%3Cnolink%3E']").each(function(index) {
                                $(this).replaceWith("<span class='nolink'>" + $(this).text() + "</span>");
                        });
                        // replace separators
                        $("a[href$='/%3Cseparator%3E']").each(function(index) {
                                $(this).replaceWith("<span class='separator'><hr></span>");
                        });
                });
        })(jQuery);
    </script>

Just replace
<$("[href=
with
$("a[href$=
that's the way it works.

Thanks 3dinfluence

Regards !

PS: This solution should be on the module and no as a JS. But if you need it urgent (as I) this JS is just fine. This must be a feature on this module.

Login or register to post comments

#13

Posted by 3dinfluence on October 21, 2011 at 5:00pm

It seems to work fine without specifying the a tag in the selector here. Although I'll agree that it's probably more efficient this way as jQuery doesn't have to look for href attributes for every object in the DOM.

I also agree this is just a hack. The real solution will have to be integrated into the module.

Login or register to post comments

#14

Posted by 3dinfluence on October 24, 2011 at 4:43pm

Alternatively if you don't want to modify your templates you can add this script by saving it without the tags to a .js file and add it to your theme by adding a line like this example to your themes.info file.

scripts[] = js/nolink_fix.js

Login or register to post comments

#15

Posted by Yucom on November 7, 2011 at 8:41am

Thanks for the JS. It was really helpful, and did what I needed. I am using the superfish-module, so I did a few changes to the script, not much, and not that I know what I am doing here, as I am not skilled with JS. I changed the "span" into an "a" again, as if you use a span, the superfish css doesn't fit anymore. Yes you can change the whole css, but for what?

Important - I am using this only for the very first parent item of a menu, the visible part. Please stick to the solution Yaazkal if you want to be on the save side!

        (function ($) {
                $(document).ready(function() {
                        // replace nolinks
                        $("a[href$='/%3Cnolink%3E']").each(function(index) {
                                $(this).replaceWith("<a class='sf-depth-1 menuparent sf-with-ul' style='cursor:pointer'>" + $(this).text() + "</a>");
                        });
                        // replace separators
                        $("a[href$='/%3Cseparator%3E']").each(function(index) {
                                $(this).replaceWith("<span class='separator'><hr></span>");
                        });
                });
        })(jQuery);

Login or register to post comments

#16

Posted by digitalexperts on November 25, 2011 at 5:50am

I am using special menu item since drupal 6. it allows you to simply put nolink as a path into menu items. I cant understand why drupal don't allows # to be entered as a link. To over come this problem and some other similar problems I usually add a Jquery file in my theme named findandreplace.js and simply add the following line into that

jQuery("[href='/%3Cnolink%3E']").attr("href", "#");

so it simply replaces the nolink into # and it worked fine with special menu and nice menu.

May be this can help some one like me who needs simple solutions for the typical problems.

Login or register to post comments

#17

Posted by kannary100 on November 27, 2011 at 6:55pm

This one to be inserted in current jQuery function.

$("a[href='/%3Cnolink%3E']").attr('href', '#');

I think yours is also missing the "a" selector:

jQuery("a[href='/%3Cnolink%3E']").attr("href", "#");

Login or register to post comments

#18

Posted by gagarine on November 28, 2011 at 1:43am

Assigned to:

Anonymous

» gagarine

Ok apparently I will have to work on this one...

Login or register to post comments

#19

Posted by markwk on February 22, 2012 at 7:46am

I can confirm http://drupal.org/node/1221294#comment-5212154 fixes issue with superfish.

Login or register to post comments

#20

Posted by axel.rutz on February 22, 2012 at 9:32am

my 5 cent here: this must be done in php, not js, to work in any case.

Login or register to post comments

#21

Posted by axel.rutz on February 22, 2012 at 9:43am

hey, just looked and it seems to be already something in the dev source.
http://drupalcode.org/project/special_menu_items.git/blob/refs/heads/7.x...

i don't use this module right now but who is interested might try a

drush vset special_menu_items_nolink_tag '<a href="#">'

(don't forget angle brackets...)
i supose there will be still issues with it but it's clear from the source where to fix this.

Login or register to post comments

#22

Posted by duckx on March 29, 2012 at 4:56am

so the issue relies on lines 49 - 57 in the .module file... Currently there is no condition where it sets the nolink or seperator tags as chosen in the config page. I modified the return value:

http://img210.imageshack.us/img210/39/croppercapture90.jpg

by replacing the span with : a href="javascript:void(0)

since its temp fix for me. I didnt have time to make a patch and actually fix it. but all the pieces are there for anyone up for the task in making a patch for it... you'll just have to do a variable_get(...) to retreive the stored

Login or register to post comments

#23

Posted by DuaelFr on May 16, 2012 at 3:57pm

Status:

active

» needs review

Hi !

Here is a two-in-one patch which :
- improves the usage of the "special_menu_items_nolink_tag" variable by including it in the "special_menu_items_link" function
- interfaces this module with core attributes system allowing to play with other modules like Menu Attributes
It applies well on the last dev version.

I hope you will enjoy it.
Regards.

PS : first point is related to comment #21

Attachment	Size
use-vars-and-attributes-1221294-23.patch	3.3 KB

Login or register to post comments

option to use <a href="#"> for "nolink" items to not break other modules

Jump to:

Issue Summary

Comments

#1

#2

#3

#4

#5

#6

#7

#8

#9

#10

#11

#12

#13

#14

#15

#16

#17

#18

#19

#20

#21

#22

#23

Project:	Special menu items module
Version:	7.x-1.x-dev
Component:	Code
Category:	task
Priority:	major
Assigned:	gagarine
Status:	needs review