DataBase Email Encryption

- You may create a branch for it (eg.: 6.x-1.0-dev)
- The date of your commits will be saved automatically, you should rather describe what you did.
- Your module will be packed into the dbtree directory later automatically, you better move your files from ./dbtree to your git root ./
- Also licence informations will be added automatically later, you have to remove your licence file

- $Id$ tagging is deprecated; GIT doesn't need it, you should simply remove it
- version = "6.x" this is for your modules version not drupals, git will do that for you too
- the .info file is no php file, you don't need php tags in it
- "some text" formatting is also not necessary in your info file; you can simply write: const_name = value text

Some code parts are well commented others are not, imho I think a well commented code is the best documentation ;-)

I was never into d6 so I can't give you a detailed code review

cheers

great work indeed. will there be a d7 version?

* 6.x-1.0 should not be a git branch, it should be a git tag
* the module files should be in the root of the repository
* remove all old CVS $Id tags, not needed anymore
* Remove LICENSE.txt, this is added automatically by drupal.org packaging
* text in README.txt should not exceed 80 characters
* "changelog.txt" should be named "CHANGELOG.txt"
* info file: version is discouraged, this is added automatically by drupal.org packaging
* "@param noting" don't document that

Hi Julien

1. "if ($mails_row['count'] > 1)" always use "{}" around if/else statements, even if it is just one line.
This often leads to bugs if you add lines later.

2. If you are implementing a hook_(), please add proper comment to it.
add "Implementation of hook_perm()" comment to dbee_perm()

3. I think you should remove comments like

/**
#-------------------------------------------------------------------------

administration functions

#-------------------------------------------------------------------------
*/

Please read comment formatting conventions document http://drupal.org/node/1354

Thanks,

Minnur

Hi Julien,

You almost there!
Please run your code through Coder module (set the servility level to "minor (most)").

Thanks,

Minnur

Hi Julien,

I am sorry, but I found one more thing.

* I noticed that you are working in the "master" branch, you should be working version specific branch.
- Moving from a master branch to a version branch - http://drupal.org/node/1127732
- Release naming conventions - http://drupal.org/node/1015226

Please make this change; commit and push your code to specific branch (in your case this should be 6.x-1.0, the one you already have).

Thank you,

Minnur

• dbee.module: @file doc block missing, see http://drupal.org/node/1354#files
• "//check if a sensitive case email exist.": There should be a space after "//" and all comments should start capitalized.
• Remove the translations folder, translations are now done on localize.drupal.org

But these are just minor nitpicks, I think this is RTBC. Now while we are waiting for the access grants to create full projects would you be so kind to do a review of the other applications pending? Just pick one from this list: http://drupal.org/project/issues/projectapplications?status=8

Thanks for your contribution, thedut! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in minde: Commit messages - providing history and credit and Release naming conventions.